From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4047EA034F; Mon, 29 Mar 2021 09:03:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B895540151; Mon, 29 Mar 2021 09:03:34 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id E2CB240042 for ; Mon, 29 Mar 2021 09:03:33 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 1DF5B5C0085; Mon, 29 Mar 2021 03:03:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 29 Mar 2021 03:03:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= xNV65D6p4C+JFN8lOM0g2s9rqE10vDL+Iaa9Oys6gAU=; b=upCT0twSX+562tsa BuSJSBfDLbCaoLCp3VMGWophhybCsWSqHkqrzNF8GAh4cQOgQWbOzKrUK8/Yfr/r qgS2lotVw7eIlCMVp3FY4+bym2j0vjWGVJYYvwboIzPPiJMbDzqj23t1V13DDzlf cfuz0gm7oXxvzJIIx+XRjqAatooX9EZote/kk8IiCEOnjg1uuY3fazniAsdF4RNf xdWpza463saNl/HrCram++b5/CbLUMI9KDQIyGJ60omjqV9QLiUZo8ExDl9aGl/o 5z1CAzDmHk1XpnLJNfn92deUoL9t4+zjlqblv/88cNbtxD29sY0bfwzJBkMF8QYE AlyXxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=xNV65D6p4C+JFN8lOM0g2s9rqE10vDL+Iaa9Oys6g AU=; b=NMlIhcJzMqIi4H5hes1t51Rza532XfcL24DrFMSVhlTRgnorEwwwyHE/J l+vavt0BZbw8+ndC3fDV+bTO+eicbiHBrOOXf69r+VxYU/l/YSBf6FEGtYIXlnhz Gen0s4uAiiI5cNqVML5sZCHfKp2ih+naCjNTlQSp6s+O1e96gzCHoBV/rWjMng5t BdZZdOxy6SAf3Z/zpJIyzcEkYHFhos5Wxyk8AQKEqGvTzvn1otxg/6eCE5ac2syH 7ET5hcNv4dG6VvGZANTfiA4tYEkrVW3jsBrImUppKfYEhgTeCN2qbcQ8z/+0ZrlY 3jidPkca1CrS3OHceNQOdTko6GQBw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehjedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 79224240065; Mon, 29 Mar 2021 03:03:31 -0400 (EDT) From: Thomas Monjalon To: Huisong Li Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Mon, 29 Mar 2021 09:03:28 +0200 Message-ID: <9105928.7imIDBDKWL@thomas> In-Reply-To: <2a9f3c44-44da-854b-8b25-772a3570baa4@huawei.com> References: <2a9f3c44-44da-854b-8b25-772a3570baa4@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Questions about reporting auto-negotiation capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/03/2021 06:02, Huisong Li: > Hi, all > > 'speed_capa' in struct rte_eth_dev_info is defined as follows: > > uint32_t speed_capa; /**< Supported speeds bitmap (ETH_LINK_SPEED_). */ > > > Most PMD drivers use this field to report the speeds capability > supported by the device to the upper-layer app. > > But it seems that few NICs report their auto-negotiation capability > through this field. If NIC also uses it to report > > their auto-negotiation capability through this field, and should set it > to ETH_LINK_SPEED_AUTONEG(0) based on > > the definition of ETH_LINK_SPEED_xxx. In this case, it conflicts the > report of the speeds capability . > > > I don't know how to correctly report the auto-negotiation capability of > the device. Thanks for your reply. ETH_LINK_SPEED_AUTONEG is not for capabilities. Anyway, if it is set, it changes nothing (0) in the bitmap. I see mlx5 is wrongly using it. speed_capa is only for enumerating speeds.