DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru,
	bruce.richardson@intel.com,
	Shepard Siegel <shepard.siegel@atomicrules.com>,
	David Marchand <david.marchand@redhat.com>,
	techboard@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers
Date: Mon, 29 Mar 2021 21:31:32 +0200
Message-ID: <9106083.eXt1UuAYbc@thomas> (raw)
In-Reply-To: <1b10aa5b-9747-87f3-bc01-e33d202c7d4c@intel.com>

29/03/2021 17:23, Ferruh Yigit:
> On 3/29/2021 1:10 PM, Thomas Monjalon wrote:
> > 29/03/2021 11:43, Ferruh Yigit:
> >> On 3/26/2021 8:52 PM, Tyler Retzlaff wrote:
> >>> On Fri, Mar 26, 2021 at 12:02:55PM +0000, Ferruh Yigit wrote:
> >>>> On 3/24/2021 4:24 PM, Tyler Retzlaff wrote:
> >>>>> On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote:
> >>>>>> 24/03/2021 12:27, Ferruh Yigit:
> >>>>>>>
> >>>>>>> But not sure how to manage the same problem for whole project, if install all
> >>>>>>> headers in one patch, or add them gradually via separate patches by time ...
> >>>>>>
> >>>>>> We did a cleanup in ethdev but not in other driver classes.
> >>>>>> When the cleanup will be done gradually, the headers
> >>>>>> must move in this new category driver_sdk_headers.
> >>>>>
> >>>>> yes, some headers are not installed now.  so they need only to have
> >>>>> their api marked __rte_internal and installed (since there should be no
> >>>>> external consumer as a function of not being installed)
> >>>>>
> >>>>> the more difficult case is where headers were installed but the api were
> >>>>> not marked __rte_internal and appear in the stable version.map. for
> >>>>> those i guess deprecation notice has to be issued before marking as
> >>>>> internal.
> >>>>>
> >>>>
> >>>> Are you referring to any specific APIs, can you share list of them?
> >>>
> >>> i can't remember the whole list but Thomas originally indicated the
> >>> following candidate list.
> >>>
> >>>       baseband/ -> librte_bbdev/rte_bbdev_pmd.h
> >>>       bus/ -> rte_bus.h
> >>>       common/ -> no interface
> >>>       crypto/ -> librte_cryptodev/rte_cryptodev_pmd.h
> >>>       event/ -> librte_eventdev/
> >>>       mempool/ -> librte_mempool/
> >>>       net/ -> librte_ethdev/
> >>>       raw/ -> librte_rawdev/rte_rawdev_pmd.h
> >>>       regex/ -> librte_regexdev/rte_regexdev_driver.h
> >>>       vdpa/ -> librte_vhost/rte_vdpa_dev.h
> >>>
> >>> some of these headers are not published, some are.
> >>>
> >>
> >> These are public headers, so they should not have '__rte_internal' functions,
> >> are you saying some of public headers has internal functions that are presented
> >> as public APIs?
> > 
> > These are the headers for use by the drivers.
> > We should classify them as SDK headers, not API.
> > 
> 
> Yes, you are right, they shouldn't be public header.
> 
> So, agree to Tyler's comment, that some of those functions needs to be removed 
> from the stable API list first, which will take time.
> 
> I can proceed with the ethdev one, any objection?

+1

> And for the rest of the list, how can we fix them? I guess best option is to 
> distribute the work to each library, but we need an owner of the task to follow 
> and communicate it.

+1
+Cc techboard



  reply	other threads:[~2021-03-29 19:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 19:27 [dpdk-dev] [PATCH] " Tyler Retzlaff
2021-03-12 15:19 ` Ferruh Yigit
2021-03-12 15:25   ` David Marchand
2021-03-12 15:34     ` Bruce Richardson
2021-03-12 15:52       ` Thomas Monjalon
2021-03-12 18:43         ` Tyler Retzlaff
2021-03-12 22:20 ` [dpdk-dev] [PATCH v2] " Tyler Retzlaff
2021-03-15 10:06   ` Bruce Richardson
2021-03-23 17:04   ` Ferruh Yigit
2021-03-24  4:32     ` Tyler Retzlaff
2021-03-24 11:27       ` Ferruh Yigit
2021-03-24 11:30         ` Thomas Monjalon
2021-03-24 16:24           ` Tyler Retzlaff
2021-03-26 12:02             ` Ferruh Yigit
2021-03-26 20:52               ` Tyler Retzlaff
2021-03-29  9:43                 ` Ferruh Yigit
2021-03-29 12:10                   ` Thomas Monjalon
2021-03-29 15:23                     ` Ferruh Yigit
2021-03-29 19:31                       ` Thomas Monjalon [this message]
2021-03-30 12:50         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9106083.eXt1UuAYbc@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=shepard.siegel@atomicrules.com \
    --cc=techboard@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git