From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B1EFA0524; Fri, 27 Nov 2020 11:05:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81751C92A; Fri, 27 Nov 2020 11:05:19 +0100 (CET) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by dpdk.org (Postfix) with ESMTP id 7B7F3C8CC for ; Fri, 27 Nov 2020 11:05:17 +0100 (CET) Received: by mail-wm1-f49.google.com with SMTP id a3so5944978wmb.5 for ; Fri, 27 Nov 2020 02:05:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=25j9fAqKB6qK1wkEM7IM9Bdv20Jzf5KcGiEgnIec1ME=; b=ZNvXylXL92owxWIBS8cV1WMCu2baRLohTjkqb+44kzqhsqeeQl4e7/GMNiRMJDk0e1 193IYMIfj+WDTFC7C+JzFQOnywbvLMY5BlFdYkIk7chPub3LDdbV/1tSRSanx6gmHLew s2FcaIAl2kmO+sB9WA4+4io34QZnKKL0K0/Wgzyu/7PYsvnJNp8WWYt0HwaUhCguqmIo dakAVS9SWsNXuFFLHbp9JpjFQDXEchk89W9rcCinz1ddl6MhxiQDJoRxJtKDws9Gdpe7 PTwjmVgMZgvPBCIg+k770zFhIMnDhNLaCIm9MRUsB1yXFeRV0WfGZG4FLD/I5KTGvtkV FAIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=25j9fAqKB6qK1wkEM7IM9Bdv20Jzf5KcGiEgnIec1ME=; b=igjz2rHlCPCCx8Q7hRB1wx/N5FMszbvYQAnOWOdH/plJ4m9ycHTtNG2SEYU2ZMJ6q4 8HYKy9vWnRSMYeTechAbXGHK/SZ5YUu0GeiPBOPQ7nGGG7VmKc6+f6zH98BJbOhMbHWJ lfjnbv8D+jG+AZNp5sjdzaneC6gj6AaWIT6F5yLHgY4fyjglR2z6h65yRGQAHyegOIwf l5BxUbGIfButOZl3fPqhLbX0D0QpriOSpyhwwQZ/p2eNga2Cy6TipNS4ZXfGbkiW5usY zriwaGuiwcU24Mv5cKPe5uiU99ZFTTEpFi6AfTjJp4cGRELgnT4hQBQlY6jcAdOgMFSM s7PA== X-Gm-Message-State: AOAM532qpP59ErNdGNZxZWaM7viPEgRf9OR10pGGqnTuKWrEgEeW/UsY oQ3PwUd76AyYa12eOJNiN1Uw1g== X-Google-Smtp-Source: ABdhPJxwXGbH67ucBaUgQv3PPKfRU38JABD2EIjfLfhgIvLTS+EhQIT8/ZzvSX0+UJiRjYj7pN+0ZA== X-Received: by 2002:a1c:5ad6:: with SMTP id o205mr7588685wmb.161.1606471516125; Fri, 27 Nov 2020 02:05:16 -0800 (PST) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id 3sm12089373wmi.24.2020.11.27.02.05.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Nov 2020 02:05:15 -0800 (PST) From: Nick Connolly X-Google-Original-From: Nick Connolly To: David Marchand , Pallavi Kadam , Bruce Richardson Cc: dev , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , "Dmitry Malloy (MESHCHANINOV)" References: Message-ID: <91117f53-99a5-e427-3e7f-162dda832b8b@mayadata.io> Date: Fri, 27 Nov 2020 10:05:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [dpdk-dev] Build error with mingw in debug mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The root cause here is that rte_windows.h shouldn't be injecting 'missing' POSIX functionality into the environment.  The header is included indirectly in application code via rte_os.h, but deciding how to implement the 'missing' functionality should be the applications responsibility. There are a number of definitions that fall in this category, so there will need to be some work done to resolve the issues. In the meantime, I'll prepare a patch that works around the specific issue you've encountered. Regards, Nick On 27/11/2020 09:53, David Marchand wrote: > This is introduced by e8428a9d89f1 ("eal/windows: add some basic > functions and macros"). > So sending to you guys: > > Caught while compiling all my envs with --buildtype=debug rather than > debugoptimized: > > ninja: Entering directory `/home/dmarchan/builds/build-x86-mingw' > ... > Build targets in project: 70 > Option buildtype is: debug [default: release] > Found ninja-1.9.0 at /usr/bin/ninja > [1/149] Compiling C object > 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj'. > FAILED: lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj > x86_64-w64-mingw32-gcc -Ilib/76b5a35@@rte_eal@sta -Ilib > -I../../dpdk/lib -I. -I../../dpdk/ -Iconfig -I../../dpdk/config > -Ilib/librte_eal/include -I../../dpdk/lib/librte_eal/include > -Ilib/librte_eal/windows/include > -I../../dpdk/lib/librte_eal/windows/include > -Ilib/librte_eal/x86/include -I../../dpdk/lib/librte_eal/x86/include > -Ilib/librte_eal/common -I../../dpdk/lib/librte_eal/common > -Ilib/librte_eal -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs > -I../../dpdk/lib/librte_kvargs -fdiagnostics-color=always -pipe -Wall > -Winvalid-pch -Werror -g -include rte_config.h -Wextra -Wcast-qual > -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security > -Wmissing-declarations -Wmissing-prototypes -Wnested-externs > -Wold-style-definition -Wpointer-arith -Wsign-compare > -Wstrict-prototypes -Wundef -Wwrite-strings > -Wno-address-of-packed-member -Wno-packed-not-aligned > -Wno-missing-field-initializers -D_GNU_SOURCE -D_WIN32_WINNT=0x0A00 > -D__USE_MINGW_ANSI_STDIO -march=native -DALLOW_EXPERIMENTAL_API > -DALLOW_INTERNAL_API -Wno-format-truncation '-DABI_VERSION="21.0"' -MD > -MQ 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj' > -MF 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj.d' > -o 'lib/76b5a35@@rte_eal@sta/librte_eal_common_eal_common_hexdump.c.obj' > -c ../../dpdk/lib/librte_eal/common/eal_common_hexdump.c > In file included from ../../dpdk/lib/librte_eal/include/rte_common.h:28, > from ../../dpdk/lib/librte_eal/include/rte_string_fns.h:21, > from ../../dpdk/lib/librte_eal/common/eal_common_hexdump.c:9: > ../../dpdk/lib/librte_eal/windows/include/rte_os.h:40: error: > "strncasecmp" redefined [-Werror] > 40 | #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count) > | > In file included from ../../dpdk/lib/librte_eal/include/rte_string_fns.h:19, > from ../../dpdk/lib/librte_eal/common/eal_common_hexdump.c:9: > /usr/x86_64-w64-mingw32/sys-root/mingw/include/string.h:119: note: > this is the location of the previous definition > 119 | #define strncasecmp _strnicmp > | > cc1: all warnings being treated as errors > >