From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 484DD425CA;
	Mon, 18 Sep 2023 07:10:39 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1EB78402D3;
	Mon, 18 Sep 2023 07:10:39 +0200 (CEST)
Received: from VLXDG1SPAM1.ramaxel.com (email.unionmem.com [221.4.138.186])
 by mails.dpdk.org (Postfix) with ESMTP id F2A0E40263
 for <dev@dpdk.org>; Mon, 18 Sep 2023 07:10:36 +0200 (CEST)
Received: from V12DG1MBS03.ramaxel.local ([172.26.18.33])
 by VLXDG1SPAM1.ramaxel.com with ESMTP id 38I5ASCT008955;
 Mon, 18 Sep 2023 13:10:28 +0800 (GMT-8)
 (envelope-from wanry@3snic.com)
Received: from [10.64.136.151] (10.64.136.151) by V12DG1MBS03.ramaxel.local
 (172.26.18.33) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.17; Mon, 18
 Sep 2023 13:10:27 +0800
Message-ID: <91316798-4195-4ad6-9f23-915092a5967e@3snic.com>
Date: Mon, 18 Sep 2023 13:10:27 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 07/32] net/sssnic/base: add mailbox support
To: Stephen Hemminger <stephen@networkplumber.org>
CC: <dev@dpdk.org>, <ferruh.yigit@amd.com>, Steven Song <steven.song@3snic.com>
References: <20230904045658.238185-1-wanry@3snic.com>
 <20230904045658.238185-8-wanry@3snic.com>
 <20230917193251.5c7444f1@hermes.local>
From: Renyong Wan <wanry@3snic.com>
In-Reply-To: <20230917193251.5c7444f1@hermes.local>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.64.136.151]
X-ClientProxiedBy: V12DG1MBS03.ramaxel.local (172.26.18.33) To
 V12DG1MBS03.ramaxel.local (172.26.18.33)
X-DNSRBL: 
X-SPAM-SOURCE-CHECK: pass
X-MAIL: VLXDG1SPAM1.ramaxel.com 38I5ASCT008955
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hello Stephen,

I'll fix it next version.

On 2023/9/18 10:32, Stephen Hemminger wrote:
> On Mon, 4 Sep 2023 12:56:33 +0800
> <wanry@3snic.com> wrote:
>
>> +struct sssnic_mbox_send_ctrl1_reg {
>> +	union {
>> +		uint32_t u32;
>> +		struct {
>> +			uint32_t resvd0 : 10;
>> +			/* Destination eventq in the mgmt cpu */
>> +			uint32_t dst_eq : 2;
>> +			/* eventq that will be informed if tx done */
>> +			uint32_t src_eq : 2;
>> +			uint32_t dma_attr : 6;
>> +			/* mailbox message size include header and body
>> +			 * must 4byte align and unit is 4byte
>> +			 */
>> +			uint32_t tx_size : 5;
>> +			uint32_t ordering : 2;
>> +			uint32_t resvd1 : 1;
>> +			/*write result back to DMA address of sending result  */
>> +			uint32_t wb : 1;
> Minor nit: the comment above has odd word spacing.

-- 
Regards,
Renyong Wan