From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BBFA42C4F for ; Tue, 23 Apr 2019 12:58:21 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD9E7C02490D; Tue, 23 Apr 2019 10:58:20 +0000 (UTC) Received: from [10.36.116.255] (unknown [10.36.116.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3AD005C3FA; Tue, 23 Apr 2019 10:58:19 +0000 (UTC) To: Nikhil Rao , thomas@monjalon.net Cc: dev@dpdk.org, jerinj@marvell.com References: <1555998614-35566-1-git-send-email-nikhil.rao@intel.com> From: Kevin Traynor Message-ID: <9137c923-0165-0834-7b0d-d2c8934ef980@redhat.com> Date: Tue, 23 Apr 2019 11:58:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1555998614-35566-1-git-send-email-nikhil.rao@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 23 Apr 2019 10:58:20 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] eventdev: add experimental tag back X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 10:58:22 -0000 On 23/04/2019 06:50, Nikhil Rao wrote: > Add the experimental tag back to the Rx event adapter callback > and the Rx event callback register functions. This patch also You should add an explanation why in the commit message. It is an unusual thing to do and the other mail thread would be too hard to find. > adds the experimental tag in the callback register > function definition and adds the function to the EXPERIMENTAL > section of the map file, these were missing previously. > > Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable") > Cc: jerinj@marvell.com > > Signed-off-by: Nikhil Rao > --- > lib/librte_eventdev/rte_event_eth_rx_adapter.h | 8 +++++++- > lib/librte_eventdev/rte_event_eth_rx_adapter.c | 9 +++++---- > lib/librte_eventdev/rte_eventdev_version.map | 6 ++++++ > 3 files changed, 18 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h > index cf23cde..32b52a7 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h > @@ -201,6 +201,9 @@ struct rte_event_eth_rx_adapter_stats { > }; > > /** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > * Callback function invoked by the SW adapter before it continues > * to process packets. The callback is passed the size of the enqueue > * buffer in the SW adapter and the occupancy of the buffer. The > @@ -437,6 +440,9 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id, > int rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id); > > /** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > * Register callback to process Rx packets, this is supported for > * SW based packet transfers. > * @see rte_event_eth_rx_cb_fn > @@ -453,7 +459,7 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id, > * - 0: Success > * - <0: Error code on failure. > */ > -int > +int __rte_experimental > rte_event_eth_rx_adapter_cb_register(uint8_t id, > uint16_t eth_dev_id, > rte_event_eth_rx_adapter_cb_fn cb_fn, > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > index 8d178be..e6001e2 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > @@ -2383,10 +2383,11 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter, > return rx_adapter->service_inited ? 0 : -ESRCH; > } > > -int rte_event_eth_rx_adapter_cb_register(uint8_t id, > - uint16_t eth_dev_id, > - rte_event_eth_rx_adapter_cb_fn cb_fn, > - void *cb_arg) > +int __rte_experimental > +rte_event_eth_rx_adapter_cb_register(uint8_t id, > + uint16_t eth_dev_id, > + rte_event_eth_rx_adapter_cb_fn cb_fn, > + void *cb_arg) > { > struct rte_event_eth_rx_adapter *rx_adapter; > struct eth_device_info *dev_info; > diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map > index 88c3ce5..9bfc666 100644 > --- a/lib/librte_eventdev/rte_eventdev_version.map > +++ b/lib/librte_eventdev/rte_eventdev_version.map > @@ -124,3 +124,9 @@ DPDK_19.05 { > rte_event_timer_arm_tmo_tick_burst; > rte_event_timer_cancel_burst; > } DPDK_18.05; > + > +EXPERIMENTAL { > + global: > + > + rte_event_eth_rx_adapter_cb_register; > +}; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D0EA9A05D3 for ; Tue, 23 Apr 2019 12:58:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E20B5323; Tue, 23 Apr 2019 12:58:23 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BBFA42C4F for ; Tue, 23 Apr 2019 12:58:21 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD9E7C02490D; Tue, 23 Apr 2019 10:58:20 +0000 (UTC) Received: from [10.36.116.255] (unknown [10.36.116.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3AD005C3FA; Tue, 23 Apr 2019 10:58:19 +0000 (UTC) To: Nikhil Rao , thomas@monjalon.net Cc: dev@dpdk.org, jerinj@marvell.com References: <1555998614-35566-1-git-send-email-nikhil.rao@intel.com> From: Kevin Traynor Message-ID: <9137c923-0165-0834-7b0d-d2c8934ef980@redhat.com> Date: Tue, 23 Apr 2019 11:58:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1555998614-35566-1-git-send-email-nikhil.rao@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 23 Apr 2019 10:58:20 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] eventdev: add experimental tag back X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423105818.uQm1HVkyXCIbjs6WLhaOJj8sqTYoeAHFVtDOubPjSO8@z> On 23/04/2019 06:50, Nikhil Rao wrote: > Add the experimental tag back to the Rx event adapter callback > and the Rx event callback register functions. This patch also You should add an explanation why in the commit message. It is an unusual thing to do and the other mail thread would be too hard to find. > adds the experimental tag in the callback register > function definition and adds the function to the EXPERIMENTAL > section of the map file, these were missing previously. > > Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable") > Cc: jerinj@marvell.com > > Signed-off-by: Nikhil Rao > --- > lib/librte_eventdev/rte_event_eth_rx_adapter.h | 8 +++++++- > lib/librte_eventdev/rte_event_eth_rx_adapter.c | 9 +++++---- > lib/librte_eventdev/rte_eventdev_version.map | 6 ++++++ > 3 files changed, 18 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h > index cf23cde..32b52a7 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h > @@ -201,6 +201,9 @@ struct rte_event_eth_rx_adapter_stats { > }; > > /** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > * Callback function invoked by the SW adapter before it continues > * to process packets. The callback is passed the size of the enqueue > * buffer in the SW adapter and the occupancy of the buffer. The > @@ -437,6 +440,9 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id, > int rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id); > > /** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > * Register callback to process Rx packets, this is supported for > * SW based packet transfers. > * @see rte_event_eth_rx_cb_fn > @@ -453,7 +459,7 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id, > * - 0: Success > * - <0: Error code on failure. > */ > -int > +int __rte_experimental > rte_event_eth_rx_adapter_cb_register(uint8_t id, > uint16_t eth_dev_id, > rte_event_eth_rx_adapter_cb_fn cb_fn, > diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > index 8d178be..e6001e2 100644 > --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c > @@ -2383,10 +2383,11 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter, > return rx_adapter->service_inited ? 0 : -ESRCH; > } > > -int rte_event_eth_rx_adapter_cb_register(uint8_t id, > - uint16_t eth_dev_id, > - rte_event_eth_rx_adapter_cb_fn cb_fn, > - void *cb_arg) > +int __rte_experimental > +rte_event_eth_rx_adapter_cb_register(uint8_t id, > + uint16_t eth_dev_id, > + rte_event_eth_rx_adapter_cb_fn cb_fn, > + void *cb_arg) > { > struct rte_event_eth_rx_adapter *rx_adapter; > struct eth_device_info *dev_info; > diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map > index 88c3ce5..9bfc666 100644 > --- a/lib/librte_eventdev/rte_eventdev_version.map > +++ b/lib/librte_eventdev/rte_eventdev_version.map > @@ -124,3 +124,9 @@ DPDK_19.05 { > rte_event_timer_arm_tmo_tick_burst; > rte_event_timer_cancel_burst; > } DPDK_18.05; > + > +EXPERIMENTAL { > + global: > + > + rte_event_eth_rx_adapter_cb_register; > +}; >