DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: --no-as-needed by default for linux exec-env
Date: Thu, 30 Oct 2014 11:05:24 +0000	[thread overview]
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004E9A0FB@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1414666662-14966-1-git-send-email-sergio.gonzalez.monroy@intel.com>

Some info about the issue for this patch:
https://wiki.ubuntu.com/ToolChain/CompilerFlags#Flags_passed_to_the_linker
https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

Basically, Ubuntu GCC is always passing --as-needed to the linker which causes some
Linking issues for us.
I'm not entirely sure that we should patch this issue or just add to the release notes.
Currently we can work around this by setting EXTRA_LDFLAGS='--no-as-needed' 

Thoughts?

Thanks,
Sergio

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
> Monroy
> Sent: Thursday, October 30, 2014 10:58 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: --no-as-needed by default for linux exec-
> env
> 
> Ubuntu/Debian toolchain passes --as-needed flag to the linker by default.
> Add --no-as-needed flag by default in linuxapp exec-env to ensure correct
> linking.
> 
> Signed-off-by: Sergio Gonzalez Monroy
> <sergio.gonzalez.monroy@intel.com>
> ---
>  mk/exec-env/linuxapp/rte.vars.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/exec-env/linuxapp/rte.vars.mk b/mk/exec-
> env/linuxapp/rte.vars.mk
> index d4808c2..79ddd5f 100644
> --- a/mk/exec-env/linuxapp/rte.vars.mk
> +++ b/mk/exec-env/linuxapp/rte.vars.mk
> @@ -45,7 +45,7 @@ else
>  EXECENV_CFLAGS  = -pthread
>  endif
> 
> -EXECENV_LDFLAGS =
> +EXECENV_LDFLAGS = --no-as-needed
>  EXECENV_LDLIBS  = -lrt -lm
>  EXECENV_ASFLAGS =
> 
> --
> 1.9.3

  reply	other threads:[~2014-10-30 10:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30 10:57 Sergio Gonzalez Monroy
2014-10-30 11:05 ` Gonzalez Monroy, Sergio [this message]
2014-10-30 14:01   ` Neil Horman
2014-10-30 16:20     ` Gonzalez Monroy, Sergio
2014-10-30 19:21       ` Neil Horman
2014-10-31  9:02         ` Gonzalez Monroy, Sergio
2014-11-05 15:02 ` De Lara Guarch, Pablo
2014-11-28 15:35 ` Thomas Monjalon
2014-11-29 15:02   ` Neil Horman
2014-11-29 20:20     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91383E96CE459D47BCE92EFBF5CE73B004E9A0FB@IRSMSX108.ger.corp.intel.com \
    --to=sergio.gonzalez.monroy@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).