From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 43BB16835
 for <dev@dpdk.org>; Thu, 30 Oct 2014 11:58:47 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 30 Oct 2014 04:07:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,285,1413270000"; d="scan'208";a="623400703"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by fmsmga002.fm.intel.com with ESMTP; 30 Oct 2014 04:06:28 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.82]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.25]) with mapi id 14.03.0195.001;
 Thu, 30 Oct 2014 11:05:25 +0000
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] mk: --no-as-needed by default for linux
 exec-env
Thread-Index: AQHP9DBuddw7LeIAtUeKj1hEPMgNGJxIeI6Q
Date: Thu, 30 Oct 2014 11:05:24 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004E9A0FB@IRSMSX108.ger.corp.intel.com>
References: <1414666662-14966-1-git-send-email-sergio.gonzalez.monroy@intel.com>
In-Reply-To: <1414666662-14966-1-git-send-email-sergio.gonzalez.monroy@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] mk: --no-as-needed by default for linux
 exec-env
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Oct 2014 10:58:47 -0000
X-List-Received-Date: Thu, 30 Oct 2014 10:58:47 -0000

Some info about the issue for this patch:
https://wiki.ubuntu.com/ToolChain/CompilerFlags#Flags_passed_to_the_linker
https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_librarie=
s

Basically, Ubuntu GCC is always passing --as-needed to the linker which cau=
ses some
Linking issues for us.
I'm not entirely sure that we should patch this issue or just add to the re=
lease notes.
Currently we can work around this by setting EXTRA_LDFLAGS=3D'--no-as-neede=
d'=20

Thoughts?

Thanks,
Sergio

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
> Monroy
> Sent: Thursday, October 30, 2014 10:58 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: --no-as-needed by default for linux exec-
> env
>=20
> Ubuntu/Debian toolchain passes --as-needed flag to the linker by default.
> Add --no-as-needed flag by default in linuxapp exec-env to ensure correct
> linking.
>=20
> Signed-off-by: Sergio Gonzalez Monroy
> <sergio.gonzalez.monroy@intel.com>
> ---
>  mk/exec-env/linuxapp/rte.vars.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/mk/exec-env/linuxapp/rte.vars.mk b/mk/exec-
> env/linuxapp/rte.vars.mk
> index d4808c2..79ddd5f 100644
> --- a/mk/exec-env/linuxapp/rte.vars.mk
> +++ b/mk/exec-env/linuxapp/rte.vars.mk
> @@ -45,7 +45,7 @@ else
>  EXECENV_CFLAGS  =3D -pthread
>  endif
>=20
> -EXECENV_LDFLAGS =3D
> +EXECENV_LDFLAGS =3D --no-as-needed
>  EXECENV_LDLIBS  =3D -lrt -lm
>  EXECENV_ASFLAGS =3D
>=20
> --
> 1.9.3