From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] cmdline: Fix broken functionality in FreeBSD
Date: Thu, 20 Nov 2014 16:42:23 +0000 [thread overview]
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004EC5751@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20141120142040.GE2609@hmsreliant.think-freely.org>
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Thursday, November 20, 2014 2:21 PM
> On Thu, Nov 20, 2014 at 02:17:13PM +0000, Sergio Gonzalez Monroy wrote:
> > Some features of the cmdline were broken in FreeBSD as a result of
> > termios not being compiled.
> >
> > Signed-off-by: Sergio Gonzalez Monroy
> > <sergio.gonzalez.monroy@intel.com>
>
> Not sure I understand the changelog above. You're removing ifdefs below
> which makes sense, but are you now assuming that BSD will be built with
> termios support, or do you need to add some alternate dependency check
> during the configuration of DPDK?
> Neil
>
Yes, I was assuming that BSD has termios support.
Is it not a fair assumption?
Sergio
next prev parent reply other threads:[~2014-11-20 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 14:17 Sergio Gonzalez Monroy
2014-11-20 14:20 ` Neil Horman
2014-11-20 16:42 ` Gonzalez Monroy, Sergio [this message]
2014-11-20 17:03 ` Neil Horman
2014-11-20 17:19 ` Bruce Richardson
2014-11-20 18:31 ` Neil Horman
2014-11-21 9:18 ` Bruce Richardson
2014-11-24 15:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91383E96CE459D47BCE92EFBF5CE73B004EC5751@IRSMSX108.ger.corp.intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).