From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id F2C098044
 for <dev@dpdk.org>; Mon,  1 Dec 2014 10:57:55 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga101.jf.intel.com with ESMTP; 01 Dec 2014 01:57:52 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,493,1413270000"; d="scan'208";a="646113743"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
 by orsmga002.jf.intel.com with ESMTP; 01 Dec 2014 01:57:50 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by
 IRSMSX109.ger.corp.intel.com ([169.254.13.244]) with mapi id 14.03.0195.001;
 Mon, 1 Dec 2014 09:57:49 +0000
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] mk: fix app linking for combined libs
Thread-Index: AQHP7tc5JcNu/JWW5EubnXp0+FxgHpx2adoAgARRQnA=
Date: Mon, 1 Dec 2014 09:57:48 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004EF7321@IRSMSX108.ger.corp.intel.com>
References: <1414078604-1090-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <6592533.mQvpkUAhuR@xps13>
In-Reply-To: <6592533.mQvpkUAhuR@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: fix app linking for combined libs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Dec 2014 09:57:57 -0000

> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, November 28, 2014 3:56 PM
>=20
> 2014-10-23 16:36, Sergio Gonzalez Monroy:
> > Building combined shared libraries results in applications being
> > linked against separeted/individual and combined libs altogether.
> >
> > Link only against combined lib when the config option is enabled.
> >
> > Signed-off-by: Sergio Gonzalez Monroy
> > <sergio.gonzalez.monroy@intel.com>
> [...]
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -217,6 +217,12 @@ endif
> >
> >  endif # plugins
> >
> > +ifeq ($(RTE_BUILD_COMBINE_LIBS),y)
> > +LDLIBS =3D --whole-archive
>=20
> You are resetting LDLIBS here.
> It's not easy to read and probably not desired.
> I think it would be better to explicitly disable separated libs in this c=
ase.
>=20
Yes, I am resetting LDLIBS so we just link against the combined lib instead=
 of all the previous separated libs.
I am not sure I understand what you mean with 'disable separated libs in th=
is case'.

Thanks,
Sergio

> > +LDLIBS +=3D --start-group
> > +LDLIBS +=3D -l$(RTE_LIBNAME)
> > +endif
>=20
> Thanks
> --
> Thomas