From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: fix app linking for combined libs
Date: Mon, 1 Dec 2014 11:15:51 +0000 [thread overview]
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004EF73BC@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1505529.uMfnAuRVUN@xps13>
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, December 1, 2014 10:35 AM
>
> By "disable separated libs", I mean enclose the LDLIBS lines for separated libs
> with ifneq ($(RTE_BUILD_COMBINE_LIBS),y) Using ifeq is more explicit than
> inserting LDLIBS= in the middle of LDLIBS+= lines.
> Do you agree?
>
That makes sense, I agree it would be easier to read that way.
I'll work on a v2.
Thanks,
Sergio
> --
> Thomas
next prev parent reply other threads:[~2014-12-01 11:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 15:36 Sergio Gonzalez Monroy
2014-10-28 16:37 ` De Lara Guarch, Pablo
2014-11-28 15:55 ` Thomas Monjalon
2014-12-01 9:57 ` Gonzalez Monroy, Sergio
2014-12-01 10:35 ` Thomas Monjalon
2014-12-01 11:15 ` Gonzalez Monroy, Sergio [this message]
2014-12-08 14:53 ` [dpdk-dev] " Neil Horman
2014-12-16 16:02 ` Thomas Monjalon
2014-12-16 23:26 ` Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91383E96CE459D47BCE92EFBF5CE73B004EF73BC@IRSMSX108.ger.corp.intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).