From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2CDE5803D
 for <dev@dpdk.org>; Mon,  1 Dec 2014 12:15:55 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 01 Dec 2014 03:15:53 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,493,1413270000"; d="scan'208";a="640633079"
Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157])
 by fmsmga002.fm.intel.com with ESMTP; 01 Dec 2014 03:15:52 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by
 IRSMSX103.ger.corp.intel.com ([169.254.3.134]) with mapi id 14.03.0195.001;
 Mon, 1 Dec 2014 11:15:52 +0000
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] mk: fix app linking for combined libs
Thread-Index: AQHP7tc5JcNu/JWW5EubnXp0+FxgHpx2adoAgARRQnCAAAwmgIAACc3A
Date: Mon, 1 Dec 2014 11:15:51 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004EF73BC@IRSMSX108.ger.corp.intel.com>
References: <1414078604-1090-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <6592533.mQvpkUAhuR@xps13>
 <91383E96CE459D47BCE92EFBF5CE73B004EF7321@IRSMSX108.ger.corp.intel.com>
 <1505529.uMfnAuRVUN@xps13>
In-Reply-To: <1505529.uMfnAuRVUN@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mk: fix app linking for combined libs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Dec 2014 11:15:56 -0000

> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, December 1, 2014 10:35 AM
>=20
> By "disable separated libs", I mean enclose the LDLIBS lines for separate=
d libs
> with ifneq ($(RTE_BUILD_COMBINE_LIBS),y) Using ifeq is more explicit than
> inserting LDLIBS=3D in the middle of LDLIBS+=3D lines.
> Do you agree?
>=20
That makes sense, I agree it would be easier to read that way.
I'll work on a v2.

Thanks,
Sergio

> --
> Thomas