DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] testpmd: remove incorrect parameter limits in help command line
@ 2015-02-06 14:22 Pablo de Lara
  2015-02-11 10:42 ` Gonzalez Monroy, Sergio
  0 siblings, 1 reply; 3+ messages in thread
From: Pablo de Lara @ 2015-02-06 14:22 UTC (permalink / raw)
  To: dev

Ring threshold parameters an RX/TX queue (pthresh, wthresh and hthresh)
had an incorrect range of values shown in help command line.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 app/test-pmd/parameters.c |   18 ++++++------------
 1 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index c7105ca..e66153d 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -171,20 +171,14 @@ usage(char* progname)
 	printf("  --txd=N: set the number of descriptors in TX rings to N.\n");
 	printf("  --burst=N: set the number of packets per burst to N.\n");
 	printf("  --mbcache=N: set the cache of mbuf memory pool to N.\n");
-	printf("  --rxpt=N: set prefetch threshold register of RX rings to N "
-	       "(0 <= N <= 16).\n");
-	printf("  --rxht=N: set the host threshold register of RX rings to N "
-	       "(0 <= N <= 16).\n");
+	printf("  --rxpt=N: set prefetch threshold register of RX rings to N.\n");
+	printf("  --rxht=N: set the host threshold register of RX rings to N.\n");
 	printf("  --rxfreet=N: set the free threshold of RX descriptors to N "
 	       "(0 <= N < value of rxd).\n");
-	printf("  --rxwt=N: set the write-back threshold register of RX rings "
-	       "to N (0 <= N <= 16).\n");
-	printf("  --txpt=N: set the prefetch threshold register of TX rings "
-	       "to N (0 <= N <= 16).\n");
-	printf("  --txht=N: set the nhost threshold register of TX rings to N "
-	       "(0 <= N <= 16).\n");
-	printf("  --txwt=N: set the write-back threshold register of TX rings "
-	       "to N (0 <= N <= 16).\n");
+	printf("  --rxwt=N: set the write-back threshold register of RX rings to N.\n");
+	printf("  --txpt=N: set the prefetch threshold register of TX rings to N.\n");
+	printf("  --txht=N: set the nhost threshold register of TX rings to N.\n");
+	printf("  --txwt=N: set the write-back threshold register of TX rings to N.\n");
 	printf("  --txfreet=N: set the transmit free threshold of TX rings to N "
 	       "(0 <= N <= value of txd).\n");
 	printf("  --txrst=N: set the transmit RS bit threshold of TX rings to N "
-- 
1.7.4.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] testpmd: remove incorrect parameter limits in help command line
  2015-02-06 14:22 [dpdk-dev] [PATCH] testpmd: remove incorrect parameter limits in help command line Pablo de Lara
@ 2015-02-11 10:42 ` Gonzalez Monroy, Sergio
  2015-02-15 15:56   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Gonzalez Monroy, Sergio @ 2015-02-11 10:42 UTC (permalink / raw)
  To: De Lara Guarch, Pablo, dev

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Friday, February 6, 2015 2:23 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] testpmd: remove incorrect parameter limits in
> help command line
> 
> Ring threshold parameters an RX/TX queue (pthresh, wthresh and hthresh)
> had an incorrect range of values shown in help command line.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  app/test-pmd/parameters.c |   18 ++++++------------
>  1 files changed, 6 insertions(+), 12 deletions(-)
> 
Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] testpmd: remove incorrect parameter limits in help command line
  2015-02-11 10:42 ` Gonzalez Monroy, Sergio
@ 2015-02-15 15:56   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-02-15 15:56 UTC (permalink / raw)
  To: De Lara Guarch, Pablo; +Cc: dev

> > Ring threshold parameters an RX/TX queue (pthresh, wthresh and hthresh)
> > had an incorrect range of values shown in help command line.
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > 
> Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-15 15:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-06 14:22 [dpdk-dev] [PATCH] testpmd: remove incorrect parameter limits in help command line Pablo de Lara
2015-02-11 10:42 ` Gonzalez Monroy, Sergio
2015-02-15 15:56   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).