Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module

["Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, October 15, 2014 1:05 PM
> To: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module
> 
> Sergio,
> 
> I'd like to see a v2 patch with your explanations in commit log and with a
> Signed-off-by.
> 
My mistake, I will be more careful to check proper comments and signed-off.
V2 on the way.

> > > -		CROSS_COMPILE=$(CROSS)
> > > +		V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS)
> 
> Minor nits:
> - paren is not needed for one letter variable


I don't mind doing this but a quick grep on the current code
will show more single letters with parenthesis than without.
I was just trying to be consistent with current style.

Thanks,
Sergio

> - V option should go to the end to keep things sorted by importance
> 
> -               CROSS_COMPILE=$(CROSS)
> +               CROSS_COMPILE=$(CROSS) V=$(if $V,1,0)
> 
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Please Pablo, do not give your ack if there is no Signed-off-by.
> It's mandatory.
> 
> Thanks
> --
> Thomas