From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id C96B37E6E
 for <dev@dpdk.org>; Wed, 15 Oct 2014 14:57:38 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 15 Oct 2014 06:05:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,724,1406617200"; d="scan'208";a="614871706"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga002.fm.intel.com with ESMTP; 15 Oct 2014 06:05:19 -0700
Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by
 IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Wed, 15 Oct 2014 14:05:17 +0100
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by
 IRSMSX152.ger.corp.intel.com ([169.254.6.118]) with mapi id 14.03.0195.001;
 Wed, 15 Oct 2014 14:05:17 +0100
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "De Lara Guarch, Pablo"
 <pablo.de.lara.guarch@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] Pass verbose flag to kernel module
Thread-Index: AQHP4YBR5vVvpVFq7E+D6FYtnE2vJ5wuLCKAgALgjQCAAB/w8A==
Date: Wed, 15 Oct 2014 13:05:16 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B0C7E872@IRSMSX108.ger.corp.intel.com>
References: <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8972262B7FB@IRSMSX108.ger.corp.intel.com>
 <6226905.S8oySLlmRr@xps13>
In-Reply-To: <6226905.S8oySLlmRr@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Oct 2014 12:57:39 -0000

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, October 15, 2014 1:05 PM
> To: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module
>=20
> Sergio,
>=20
> I'd like to see a v2 patch with your explanations in commit log and with =
a
> Signed-off-by.
>=20
My mistake, I will be more careful to check proper comments and signed-off.
V2 on the way.

> > > -		CROSS_COMPILE=3D$(CROSS)
> > > +		V=3D$(if $(V),1,0) CROSS_COMPILE=3D$(CROSS)
>=20
> Minor nits:
> - paren is not needed for one letter variable


I don't mind doing this but a quick grep on the current code
will show more single letters with parenthesis than without.
I was just trying to be consistent with current style.

Thanks,
Sergio

> - V option should go to the end to keep things sorted by importance
>=20
> -               CROSS_COMPILE=3D$(CROSS)
> +               CROSS_COMPILE=3D$(CROSS) V=3D$(if $V,1,0)
>=20
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>=20
> Please Pablo, do not give your ack if there is no Signed-off-by.
> It's mandatory.
>=20
> Thanks
> --
> Thomas