From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Set V=1 when building kernel modules
Date: Wed, 15 Oct 2014 13:43:15 +0000 [thread overview]
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B0C7E8B6@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1413378491-15573-1-git-send-email-sergio.gonzalez.monroy@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
> Monroy
> Sent: Wednesday, October 15, 2014 2:08 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] Set V=1 when building kernel modules
>
Self-NACK.
Please ignore as I forgot to add v2 prefix.
Sergio
> Linux kernel build system requires V=1 to enable verbose output, but current
> DPDK framework just check if V is defined.
>
> Fix: force V=1 when building Linux kernel modules if verbose output is
> enabled.
>
> Signed-off-by: Sergio Gonzalez Monroy
> <sergio.gonzalez.monroy@intel.com>
> ---
> mk/rte.module.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mk/rte.module.mk b/mk/rte.module.mk index c4ca3fd..34a2ba9
> 100644
> --- a/mk/rte.module.mk
> +++ b/mk/rte.module.mk
> @@ -78,7 +78,7 @@ build: _postbuild
> $(MODULE).ko: $(SRCS_LINKS)
> @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
> @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR)
> O=$(RTE_KERNELDIR) \
> - CROSS_COMPILE=$(CROSS)
> + CROSS_COMPILE=$(CROSS) V=$(if $V,1,0)
>
> # install module in $(RTE_OUTPUT)/kmod
> $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko
> --
> 1.9.3
next prev parent reply other threads:[~2014-10-15 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 16:09 [dpdk-dev] [PATCH] Pass verbose flag to kernel module Sergio Gonzalez Monroy
2014-10-08 17:05 ` Thomas Monjalon
2014-10-09 9:37 ` Sergio Gonzalez Monroy
2014-10-09 12:15 ` Thomas Monjalon
2014-10-13 16:08 ` De Lara Guarch, Pablo
2014-10-15 12:04 ` Thomas Monjalon
2014-10-15 13:05 ` Gonzalez Monroy, Sergio
2014-10-15 13:08 ` [dpdk-dev] [PATCH] Set V=1 when building kernel modules Sergio Gonzalez Monroy
2014-10-15 13:43 ` Gonzalez Monroy, Sergio [this message]
2014-10-15 13:08 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
2014-10-15 14:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91383E96CE459D47BCE92EFBF5CE73B0C7E8B6@IRSMSX108.ger.corp.intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).