From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 62A5358D7
 for <dev@dpdk.org>; Wed, 15 Oct 2014 15:36:03 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga103.jf.intel.com with ESMTP; 15 Oct 2014 06:40:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,724,1406617200"; d="scan'208";a="619099896"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by orsmga002.jf.intel.com with ESMTP; 15 Oct 2014 06:43:26 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by
 IRSMSX101.ger.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0195.001;
 Wed, 15 Oct 2014 14:43:16 +0100
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] Set V=1 when building kernel modules
Thread-Index: AQHP6H13VIe2qDkzWkicq9exkJqyi5wxKrFQ
Date: Wed, 15 Oct 2014 13:43:15 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B0C7E8B6@IRSMSX108.ger.corp.intel.com>
References: <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1413378491-15573-1-git-send-email-sergio.gonzalez.monroy@intel.com>
In-Reply-To: <1413378491-15573-1-git-send-email-sergio.gonzalez.monroy@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] Set V=1 when building kernel modules
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Oct 2014 13:36:04 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
> Monroy
> Sent: Wednesday, October 15, 2014 2:08 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] Set V=3D1 when building kernel modules
>=20
Self-NACK.
Please ignore as I forgot to add v2 prefix.

Sergio

> Linux kernel build system requires V=3D1 to enable verbose output, but cu=
rrent
> DPDK framework just check if V is defined.
>=20
> Fix: force V=3D1 when building Linux kernel modules if verbose output is
> enabled.
>=20
> Signed-off-by: Sergio Gonzalez Monroy
> <sergio.gonzalez.monroy@intel.com>
> ---
>  mk/rte.module.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/mk/rte.module.mk b/mk/rte.module.mk index c4ca3fd..34a2ba9
> 100644
> --- a/mk/rte.module.mk
> +++ b/mk/rte.module.mk
> @@ -78,7 +78,7 @@ build: _postbuild
>  $(MODULE).ko: $(SRCS_LINKS)
>  	@if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
>  	@$(MAKE) -C $(RTE_KERNELDIR) M=3D$(CURDIR)
> O=3D$(RTE_KERNELDIR) \
> -		CROSS_COMPILE=3D$(CROSS)
> +		CROSS_COMPILE=3D$(CROSS) V=3D$(if $V,1,0)
>=20
>  # install module in $(RTE_OUTPUT)/kmod
>  $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko
> --
> 1.9.3