From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C3C667E7A for ; Tue, 21 Oct 2014 11:35:27 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 21 Oct 2014 02:33:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,761,1406617200"; d="scan'208";a="608596018" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 21 Oct 2014 02:43:40 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by IRSMSX101.ger.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0195.001; Tue, 21 Oct 2014 10:43:40 +0100 From: "Gonzalez Monroy, Sergio" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 0/6] Update libs build process Thread-Index: AQHP48Hmw5W1lP9A7Ue0L3JVDzqgbJwuNZcwgAwpdQA= Date: Tue, 21 Oct 2014 09:43:39 +0000 Message-ID: <91383E96CE459D47BCE92EFBF5CE73B0C7F7E6@IRSMSX108.ger.corp.intel.com> References: <1412592755-3370-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1412859898-29068-1-git-send-email-sergio.gonzalez.monroy@intel.com> <91383E96CE459D47BCE92EFBF5CE73B0C7E2B6@IRSMSX108.ger.corp.intel.com> In-Reply-To: <91383E96CE459D47BCE92EFBF5CE73B0C7E2B6@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 0/6] Update libs build process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2014 09:35:28 -0000 Hi Thomas, Given that most of the comments/discussion for this patch set revolved=20 around the removal of COMBINE_LIBS and what libs to build by default,=20 I am inclined to drop this patch set, submit minimal patch to fix=20 compiler errors (initial and main purpose of this patch set) and then=20 submit an RFC regarding the use/removal of COMBINE_LIBS and other outstandi= ng issues in the build system. Does that sound like a better approach? Thanks, Sergio > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gonzalez Monroy, > Sergio > Sent: Monday, October 13, 2014 5:02 PM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/6] Update libs build process >=20 > Are there any more comments on this patch set? >=20 > Thanks, > Sergio >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez > > Monroy > > Sent: Thursday, October 9, 2014 2:05 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v3 0/6] Update libs build process > > > > As per the proposal, this patch set does: > > - Remove CONFIG_RTE_BUILD_COMBINE_LIBS as a configuration option. > > - For static library, build a single/combined library. > > - For shared libraries, build both individual/separated and single/com= bined > > libraries. > > - Link apps only against single/combined libs. > > - Include external shared libs dependencies when building shared libra= ries. > > > > v3: > > - Split some of the patches for easier review > > - Improve patches descriptions > > > > Sergio Gonzalez Monroy (6): > > Link combined shared library using CC > > Link apps only against single/combined library > > Remove CONFIG_RTE_BUILD_COMBINE_LIBS and related > > Update library build process > > Avoid duplicated code > > Link apps/DSOs against EXECENV_LDLIBS with --as-needed > > > > config/common_bsdapp | 3 +- > > config/common_linuxapp | 3 +- > > mk/rte.app.mk | 164 ++---------------------------------------= -------- > > mk/rte.lib.mk | 81 ++++++------------------ > > mk/rte.sdkbuild.mk | 2 +- > > mk/rte.sharelib.mk | 54 ++++++++-------- > > mk/rte.vars.mk | 4 -- > > 7 files changed, 54 insertions(+), 257 deletions(-) > > > > -- > > 1.9.3