From: Thomas Monjalon <thomas@monjalon.net>
To: Robin Jarry <rjarry@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Jerin Jacob <jerinjacobk@gmail.com>,
fengchengwen <fengchengwen@huawei.com>
Cc: dev@dpdk.org, skori@marvell.com
Subject: Re: [PATCH 1/2] usertools/rss: add driver abstractions
Date: Thu, 23 Nov 2023 00:27:24 +0100 [thread overview]
Message-ID: <9141995.lOV4Wx5bFT@thomas> (raw)
In-Reply-To: <a125e281-ae11-5ed1-be6c-b39b36bafacc@huawei.com>
22/11/2023 10:37, fengchengwen:
> On 2023/11/22 16:28, Robin Jarry wrote:
> > Stephen Hemminger, Nov 21, 2023 at 18:27:
> >> On Tue, 21 Nov 2023 22:51:19 +0530
> >> Jerin Jacob <jerinjacobk@gmail.com> wrote:
> >> > IMO, That may be too much of non-productive work to save a couple of
> >> > lines(seed array) of duplicate code between c and python.
> >>
> >> But the tool is incomplete right now, it doesn't cover all the drivers.
> >
> > I agree that having a standard API or mechanism for drivers to expose their default redirection table size and hash seed key would be nice. The script could have a dynamically generated section that is populated during the build based on selected drivers.
> >
> > However, it would make the python script dependant on it and it would not be a standalone tool anymore. This is not a blocking issue but something to keep in mind.
>
> The usertools/dpdk-pmdinfo.py will parse dpdk elf to get some information, We could do same thing in here.
We can imagine different things to avoid listing few RSS keys in this script.
For now, this series is an improvement, so I take it.
Feel free to follow-up with more enhancements.
prev parent reply other threads:[~2023-11-22 23:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 8:07 Robin Jarry
2023-10-23 8:07 ` [PATCH 2/2] usertools/rss: add --info flag Robin Jarry
2023-11-20 13:28 ` [PATCH 1/2] usertools/rss: add driver abstractions Robin Jarry
2023-11-20 15:13 ` [EXT] " Sunil Kumar Kori
2023-11-20 16:22 ` [PATCH v2 1/3] " Robin Jarry
2023-11-20 16:22 ` [PATCH v2 2/3] usertools/rss: add --info flag Robin Jarry
2023-11-21 6:15 ` [EXT] " Sunil Kumar Kori
2023-11-20 16:22 ` [PATCH v2 3/3] usertools/rss: add CNXK well-known key Robin Jarry
2023-11-20 16:41 ` Stephen Hemminger
2023-11-21 6:08 ` [EXT] " Sunil Kumar Kori
2023-11-21 6:14 ` [EXT] [PATCH v2 1/3] usertools/rss: add driver abstractions Sunil Kumar Kori
2023-11-22 23:43 ` Thomas Monjalon
2023-11-21 6:11 ` [EXT] [PATCH 1/2] " Sunil Kumar Kori
2023-11-21 16:38 ` Stephen Hemminger
2023-11-21 16:49 ` Thomas Monjalon
2023-11-21 16:51 ` Jerin Jacob
2023-11-21 17:04 ` Stephen Hemminger
2023-11-21 17:21 ` Jerin Jacob
2023-11-21 17:27 ` Stephen Hemminger
2023-11-22 8:28 ` Robin Jarry
2023-11-22 9:37 ` fengchengwen
2023-11-22 23:27 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9141995.lOV4Wx5bFT@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=jerinjacobk@gmail.com \
--cc=rjarry@redhat.com \
--cc=skori@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).