From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41866A0350; Tue, 23 Jun 2020 19:36:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCA581D6C5; Tue, 23 Jun 2020 19:36:22 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9636B1D6C2; Tue, 23 Jun 2020 19:36:21 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id F1DBD5C020A; Tue, 23 Jun 2020 13:36:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 23 Jun 2020 13:36:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= q3WTp/rTZY0ypRNYKF1KW0+LdGTkTX0cm9VOfp4O6/s=; b=e1st2gvURM9Q7PyP hcoes6Q2DH8rcArRn0u01MJJBIZNssUUQmo/+WuR2L1BJDCHDeb9mK8ymqTVIqjN ZI8o+wVimmBwe548NZHHnXhLcrPq/aEgOnswgPjs4SkV/v54Io40gONaGlJ1eSNh PcwWH9OGHq9wXCxLJ9kfiInmyUK/HaLx/fxMQ6o67JaaLArl1sQfdDI2Ps5E+z0k 7+0+EseDf/n3DO16FQAgtRG1Q9RC3OIjl07XWK6GP2bfoqTmwwIM15c95qFlVXcP NbhsnFvwojpO0SkvMF0tW0KdgMUcZaV0GuhZ3o3CAB4nfkElcLgaaoHGBmPSO+jn sDVuUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=q3WTp/rTZY0ypRNYKF1KW0+LdGTkTX0cm9VOfp4O6 /s=; b=ic2fT3y8NVs4uhgwHpJI0GyopLadOsgKGlVWzS1uQXE7dtiaHB+i6OYRR zpSUyW33qs8qKu2pKI1l3GShhJN+g9Q9RwVoawa/wq5FxMnOV8NpyQgeP97JmQnb VC0Z0tKzNkqnx3HaAdPEV0TvOoCRx7IY8lzupHHzWLCBLHxkdXM+4dGabd6Xxbp3 A/fInhrgVU0hLcNpIDittIf0VaQU52pk8xp8K01P9bQocYZ3WqXLpTb+Lo/Ystt8 43TaaAdroOJDJAgYaZzyFehrwf3+5YcPCoR271s3cq1ds8jrBV15t8lqPBGLW7z9 06tn4S2zcPk73Mxmmp6qHN29mplTQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekhedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6FB093280068; Tue, 23 Jun 2020 13:36:19 -0400 (EDT) From: Thomas Monjalon To: Fady Bader Cc: dev@dpdk.org, stable@dpdk.org, talshn@mellanox.com, fady@mellanox.com, tbashar@mellanox.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, pallavi.kadam@intel.com, ranjit.menon@intel.com, cristian.dumitrescu@intel.com Date: Tue, 23 Jun 2020 19:36:18 +0200 Message-ID: <9144704.TjrKS6luVr@thomas> In-Reply-To: <20200617082431.23156-1-fady@mellanox.com> References: <20200617081507.22868-1-fady@mellanox.com> <20200617082431.23156-1-fady@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] meter: remove inline functions from export list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/06/2020 10:24, Fady Bader: > The code didn't compile when using exported meter functions under windows. > > error LNK2001: unresolved external symbol > rte_meter_srtcm_color_aware_check > error LNK2001: unresolved external symbol > rte_meter_srtcm_color_blind_check > error LNK2001: unresolved external symbol > rte_meter_trtcm_color_aware_check > error LNK2001: unresolved external symbol > rte_meter_trtcm_color_blind_check > error LNK2001: unresolved external symbol > rte_meter_trtcm_rfc4115_color_aware_check > error LNK2001: unresolved external symbol > rte_meter_trtcm_rfc4115_color_blind_check > > The cause was that there were some inline functions that were included in > the export list. > To solve this the functions were removed from rte_meter_version.map export > list which are implemented in the header and shouldn't be exported. > > Fixes: 655796d2b5fb3d44166e172 ("meter: support RFC4115 trTCM") > Fixes: 9d41beed24b01666913de30 ("lib: provide initial versioning") > Cc: stable@dpdk.org > > Signed-off-by: Fady Bader Applied, thanks