From: Thomas Monjalon <thomas@monjalon.net>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: dev@dpdk.org, "Wang, Yipeng1" <yipeng1.wang@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"gavin.hu@arm.com" <gavin.hu@arm.com>,
"ruifeng.wang@arm.com" <ruifeng.wang@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free
Date: Mon, 08 Jul 2019 20:10:06 +0200 [thread overview]
Message-ID: <9160680.xFTE47SOSJ@xps> (raw)
In-Reply-To: <D2C4A16CA39F7F4E8E384D204491D7A673ED3E1E@ORSMSX104.amr.corp.intel.com>
08/07/2019 18:51, Wang, Yipeng1:
>From: Thomas Monjalon [mailto:thomas@monjalon.net]
> >02/07/2019 23:16, Honnappa Nagarahalli:
> >> v2
> >> - Dropped moving the tbl_chng_cnt to the beginning of the cache line
> >> commit
> >> - Changed the commit log for patch 1 to indicate that it improves
> >> performance (Yipeng)
> >> - Changed the comment in the search_one_bucket_lf function (Yipeng)
> >> - Changed the commit log for patch2 to indicate that changes to
> >> store-release of 'pdata' is cosmetic (Yipeng)
> >>
> >> Honnappa Nagarahalli (2):
> >> lib/hash: use ordered loads only if signature matches
> >> lib/hash: load pData after full key compare
> >
> >This series is missing 19.08 because of a lack of review.
> >It was expected because it was sent late in 19.08 cycle,
> >so this is just to make the status clear: it will be considered for 19.11.
>
> [Wang, Yipeng] Hi, Thomas, Thanks for your work.
> I finished the review of this patch, I think it is good to go.
> Please include it if it is convenient for you.
> Honnappa confirmed that my understanding of the code is correct, and it should help performance.
Applied, thanks
prev parent reply other threads:[~2019-07-08 18:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 21:15 [dpdk-dev] [PATCH 0/3] " Honnappa Nagarahalli
2019-06-25 21:15 ` [dpdk-dev] [PATCH 1/3] lib/hash: use ordered loads only if signature matches Honnappa Nagarahalli
2019-06-28 18:04 ` Wang, Yipeng1
2019-06-25 21:15 ` [dpdk-dev] [PATCH 2/3] lib/hash: load pData after full key compare Honnappa Nagarahalli
2019-06-28 18:40 ` Wang, Yipeng1
2019-07-02 4:35 ` Honnappa Nagarahalli
2019-07-04 0:39 ` Wang, Yipeng1
2019-07-05 5:33 ` Honnappa Nagarahalli
2019-07-08 16:44 ` Wang, Yipeng1
2019-06-25 21:15 ` [dpdk-dev] [PATCH 3/3] lib/hash: adjust tbl_chng_cnt position Honnappa Nagarahalli
2019-06-28 18:50 ` Wang, Yipeng1
2019-07-02 17:23 ` Honnappa Nagarahalli
2019-07-04 0:52 ` Wang, Yipeng1
2019-07-02 21:16 ` [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free Honnappa Nagarahalli
2019-07-02 21:16 ` [dpdk-dev] [PATCH v2 1/2] lib/hash: use ordered loads only if signature matches Honnappa Nagarahalli
2019-07-02 21:16 ` [dpdk-dev] [PATCH v2 2/2] lib/hash: load pData after full key compare Honnappa Nagarahalli
2019-07-04 11:13 ` [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free Jerin Jacob Kollanukkaran
2019-07-05 6:08 ` Honnappa Nagarahalli
2019-07-04 16:09 ` Thomas Monjalon
2019-07-05 6:14 ` Honnappa Nagarahalli
2019-07-05 6:29 ` Thomas Monjalon
2019-07-08 16:51 ` Wang, Yipeng1
2019-07-08 18:10 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9160680.xFTE47SOSJ@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=sameh.gobriel@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).