From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03919A00E6 for ; Mon, 8 Jul 2019 20:10:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D53921B955; Mon, 8 Jul 2019 20:10:11 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D6E9D1B954 for ; Mon, 8 Jul 2019 20:10:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 651C422077; Mon, 8 Jul 2019 14:10:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 08 Jul 2019 14:10:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=67xPyDOUEKacrveQGG67T7ijpFEd6yQzaMFITtzP7jQ=; b=YCSgpjteqz9l ySg59YnVCs2QH+nv62yGr7p+T3cTTBjDfL3ihdWEdpFJJbIIq6i6LUIZJY7GXP35 65kH0ryctlf6c/FwVlAGCQZqzy7v4lkxO7mTcGfrydU5KL9mqwsG9Ihtt2HJZ32m NJdg4Aah9QAGnPekDtxRDQdnBR7Fq/E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=67xPyDOUEKacrveQGG67T7ijpFEd6yQzaMFITtzP7 jQ=; b=jo57qw4AbiE2fY9+DVO8IsbNCYSMoQIbHIupKlW07po1+oTtjRqGoE1Bg t3KcKxNyeabD31gYk+a7t5O1p/0FBivHAcDeBiUZsYQhqGOgQH4ONNkProx3F/ZU 5qeDVi6ZGOdqzwL+f2FsiXb1L17WBzPzE4X/RWU/vEfF8Sp9slARCW/wqdNlazFQ bVVSK6PSLTjVSyI0TKrOCUt6WWuhNyPgT7gbsQilg2rUuOx4qDJ/l81YYTB1tDZo /GBa0dVDE1BtTzs7KmNOFtJsO0phCti8SmgBCvDi654xVGuBjGlMNcyj9zU/Bonf MsgiHHhC0wVncBFRiYlSOj4rD6U0A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgedtgdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A272F380089; Mon, 8 Jul 2019 14:10:07 -0400 (EDT) From: Thomas Monjalon To: Honnappa Nagarahalli Cc: dev@dpdk.org, "Wang, Yipeng1" , "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "gavin.hu@arm.com" , "ruifeng.wang@arm.com" , "nd@arm.com" Date: Mon, 08 Jul 2019 20:10:06 +0200 Message-ID: <9160680.xFTE47SOSJ@xps> In-Reply-To: References: <20190625211520.43181-1-honnappa.nagarahalli@arm.com> <1762755.dMxNbvATuU@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/07/2019 18:51, Wang, Yipeng1: >From: Thomas Monjalon [mailto:thomas@monjalon.net] > >02/07/2019 23:16, Honnappa Nagarahalli: > >> v2 > >> - Dropped moving the tbl_chng_cnt to the beginning of the cache line > >> commit > >> - Changed the commit log for patch 1 to indicate that it improves > >> performance (Yipeng) > >> - Changed the comment in the search_one_bucket_lf function (Yipeng) > >> - Changed the commit log for patch2 to indicate that changes to > >> store-release of 'pdata' is cosmetic (Yipeng) > >> > >> Honnappa Nagarahalli (2): > >> lib/hash: use ordered loads only if signature matches > >> lib/hash: load pData after full key compare > > > >This series is missing 19.08 because of a lack of review. > >It was expected because it was sent late in 19.08 cycle, > >so this is just to make the status clear: it will be considered for 19.11. > > [Wang, Yipeng] Hi, Thomas, Thanks for your work. > I finished the review of this patch, I think it is good to go. > Please include it if it is convenient for you. > Honnappa confirmed that my understanding of the code is correct, and it should help performance. Applied, thanks