From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01340A0A02; Wed, 24 Mar 2021 11:59:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74E214067B; Wed, 24 Mar 2021 11:59:25 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id A8A3D4014F for ; Wed, 24 Mar 2021 11:59:24 +0100 (CET) IronPort-SDR: 67fiCv9y7NSAZPvVzYVTWmgAx/0eC1JiaPGKZwdNfFHzsSua0Q7vUR7pohojgdD01AlF5ja6ac R4cmHjRznMcg== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="254673373" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="254673373" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 03:59:23 -0700 IronPort-SDR: X37hPvfKphEeaE4XnKk85/B/pCpDvknbgrHlOzW6D3myhUOLoM5qaV+dO0qFBYuzn4JrnXUxTu W/YvH1iXPXUQ== X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="408790409" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.28.141]) ([10.252.28.141]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 03:59:22 -0700 To: Jiawen Wu , dev@dpdk.org References: <20210316105149.110904-1-jiawenwu@trustnetic.com> <20210316105149.110904-3-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <9160c9a1-9b93-4fc8-6c39-5f807ea9722c@intel.com> Date: Wed, 24 Mar 2021 10:59:18 +0000 MIME-Version: 1.0 In-Reply-To: <20210316105149.110904-3-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/7] net/txgbe: add device arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/16/2021 10:51 AM, Jiawen Wu wrote: > Add device arguments to support runtime options. These arguments are > only set for backplane NICs. > > Signed-off-by: Jiawen Wu <...> > + > +#define TXGBE_DEVARG_BP_AUTO "auto" > +#define TXGBE_DEVARG_KR_POLL "poll" > +#define TXGBE_DEVARG_KR_PRESENT "present" > +#define TXGBE_DEVARG_KX_SGMII "sgmii" > +#define TXGBE_DEVARG_FFE_SET "ffe_set" > +#define TXGBE_DEVARG_FFE_MAIN "ffe_main" > +#define TXGBE_DEVARG_FFE_PRE "ffe_pre" > +#define TXGBE_DEVARG_FFE_POST "ffe_post" > + I just recognized that this patch is adding devargs without using them, and later patches are using them. This separates them from the full context. Can you please add them gradually as they are used, in the same patch they are used? Meanwhile you can add the release notes update in next version. Thanks, ferruh