* [dpdk-dev] [PATCH] net/ark: fix kvargs memory leak
@ 2017-04-28 7:43 Ferruh Yigit
2017-05-01 20:36 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-04-28 7:43 UTC (permalink / raw)
To: Shepard Siegel; +Cc: dev, Ferruh Yigit
Coverity issue: 1428042
Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Please check next-net coverity project for more issues detected:
https://scan.coverity.com/projects/dpdk-next-net?tab=overview
---
drivers/net/ark/ark_ethdev.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 4caad98..83961f5 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -922,6 +922,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params)
struct rte_kvargs *kvlist;
unsigned int k_idx;
struct rte_kvargs_pair *pair = NULL;
+ int ret = -1;
kvlist = rte_kvargs_parse(params, valid_arguments);
if (kvlist == NULL)
@@ -942,7 +943,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params)
&process_pktdir_arg,
ark) != 0) {
PMD_DRV_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTDIR_ARG);
- return -1;
+ goto free_kvlist;
}
if (rte_kvargs_process(kvlist,
@@ -950,7 +951,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params)
&process_file_args,
ark->pkt_gen_args) != 0) {
PMD_DRV_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTGEN_ARG);
- return -1;
+ goto free_kvlist;
}
if (rte_kvargs_process(kvlist,
@@ -958,7 +959,7 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params)
&process_file_args,
ark->pkt_chkr_args) != 0) {
PMD_DRV_LOG(ERR, "Unable to parse arg %s\n", ARK_PKTCHKR_ARG);
- return -1;
+ goto free_kvlist;
}
PMD_DRV_LOG(INFO, "packet director set to 0x%x\n", ark->pkt_dir_v);
@@ -980,7 +981,12 @@ eth_ark_check_args(struct ark_adapter *ark, const char *params)
ark_pktchkr_setup(ark->pc);
}
- return 0;
+ ret = 0;
+
+free_kvlist:
+ rte_kvargs_free(kvlist);
+
+ return ret;
}
RTE_PMD_REGISTER_PCI(net_ark, rte_ark_pmd);
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ark: fix kvargs memory leak
2017-04-28 7:43 [dpdk-dev] [PATCH] net/ark: fix kvargs memory leak Ferruh Yigit
@ 2017-05-01 20:36 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-05-01 20:36 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Shepard Siegel, Ed Czeck, John Miller
28/04/2017 09:43, Ferruh Yigit:
> Coverity issue: 1428042
> Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: John Miller <john.miller@atomicrules.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH] net/ark: fix kvargs memory leak
@ 2017-05-01 16:01 john miller
0 siblings, 0 replies; 3+ messages in thread
From: john miller @ 2017-05-01 16:01 UTC (permalink / raw)
To: ferruh.yigit, dev; +Cc: Shepard Siegel, Ed Czeck
Coverity issue: 1428042
Fixes: 1131cbf0fb2b ("net/ark: stub PMD for Atomic Rules Arkville")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: John Miller <john.miller@atomicrules.com <mailto:john.miller@atomicrules.com>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-01 20:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-28 7:43 [dpdk-dev] [PATCH] net/ark: fix kvargs memory leak Ferruh Yigit
2017-05-01 20:36 ` Thomas Monjalon
2017-05-01 16:01 john miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).