From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6DD0B1B640 for ; Mon, 23 Oct 2017 16:39:16 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2017 07:39:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,423,1503385200"; d="scan'208";a="141264209" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga004.jf.intel.com with ESMTP; 23 Oct 2017 07:39:15 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 23 Oct 2017 07:39:14 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.115]) by FMSMSX152.amr.corp.intel.com ([169.254.6.196]) with mapi id 14.03.0319.002; Mon, 23 Oct 2017 07:39:14 -0700 From: "Eads, Gage" To: Olivier Matz , "thomas@monjalon.net" CC: "santosh.shukla@caviumnetworks.com" , "Richardson, Bruce" , "jerin.jacob@caviumnetworks.com" , "dev@dpdk.org" Thread-Topic: [PATCH 0/3] mk: fix LDLIBS Thread-Index: AQHTQ3P737TXwCRAT06RT47rh1SpQKLxkTBg Date: Mon, 23 Oct 2017 14:39:14 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E1400B993@FMSMSX108.amr.corp.intel.com> References: <20171005125017.GA12160@bricha3-MOBL3.ger.corp.intel.com> <20171012160421.8337-1-olivier.matz@6wind.com> In-Reply-To: <20171012160421.8337-1-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2JiYWZmMjktZTVkZC00NzQ5LWFjYzItMGUzZGEyNTFlY2NiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlozanRNWkRURHZpUEQ2RUdyK0pDdkp5cHlQeFFTaStwRVRDUU5ObEtRS0k9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] mk: fix LDLIBS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 14:39:16 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Thursday, October 12, 2017 11:04 AM > To: thomas@monjalon.net > Cc: Eads, Gage ; santosh.shukla@caviumnetworks.com; > Richardson, Bruce ; > jerin.jacob@caviumnetworks.com; dev@dpdk.org > Subject: [PATCH 0/3] mk: fix LDLIBS >=20 > Some libraries in LDLIBS are currently generated from the > DEPDIRS-$(dirname) variables in the Makefiles. This is valid when the > subdirectory name match the library name, but it's not always the case, > especially for PMDs. >=20 > This series fixes some invalid dependency declarations first, and then re= moves > the automatic generation of libraries from the directory names. Instead, = the > libraries are explicitly added in each Makefile. >=20 These three patches look good. I tested it on the contrived example from my= original email, and this appears to fix the issue. Once the third patch's apply issues are resolved (http://dpdk.org/ml/archiv= es/test-report/2017-October/032631.html): Reviewed-by: Gage Eads Thanks, Gage