From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 63C902BB5 for ; Fri, 1 Mar 2019 22:29:14 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2019 13:29:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,429,1544515200"; d="scan'208";a="120227216" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 01 Mar 2019 13:29:12 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 1 Mar 2019 13:29:12 -0800 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.86]) by FMSMSX125.amr.corp.intel.com ([169.254.2.121]) with mapi id 14.03.0415.000; Fri, 1 Mar 2019 13:29:12 -0800 From: "Eads, Gage" To: Thomas Monjalon CC: Olivier Matz , "dev@dpdk.org" , "arybchenko@solarflare.com" , "Richardson, Bruce" , "Ananyev, Konstantin" , "gavin.hu@arm.com" , "Honnappa.Nagarahalli@arm.com" , "nd@arm.com" Thread-Topic: FW: [PATCH 5/7] stack: add non-blocking stack implementation Thread-Index: AQHUzP1AVsOG97wNrUa950j08RJpD6X0l4KggAKvewCAAIw1gP//fl7w Date: Fri, 1 Mar 2019 21:29:11 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E541EE4AB@FMSMSX108.amr.corp.intel.com> References: <20190222160655.3346-1-gage.eads@intel.com> <2EC44CCD3517A842B44C82651A5557A14AF13386@fmsmsx118.amr.corp.intel.com> <9184057F7FC11744A2107296B6B8EB1E541EE3BD@FMSMSX108.amr.corp.intel.com> <16181918.9taCLPWhEn@xps> In-Reply-To: <16181918.9taCLPWhEn@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjBmMDdmYTctYzUwYi00MzRjLWI5ODctMTg1NjQ4YWEwZTQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMnhZNjdNZzZrZE84Q1wvR1wvdEd0TFcxblV3UUE3S0JiNG1KOXIxUFB5KzRYUHJtMGI3UE9RYlBrK1JZSkdiZ1lUIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] FW: [PATCH 5/7] stack: add non-blocking stack implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 21:29:14 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, March 1, 2019 3:13 PM > To: Eads, Gage > Cc: Olivier Matz ; dev@dpdk.org; > arybchenko@solarflare.com; Richardson, Bruce = ; > Ananyev, Konstantin ; gavin.hu@arm.com; > Honnappa.Nagarahalli@arm.com; nd@arm.com > Subject: Re: FW: [PATCH 5/7] stack: add non-blocking stack implementation >=20 > 01/03/2019 21:53, Eads, Gage: > > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > > On Fri, Feb 22, 2019 at 10:06:53AM -0600, Gage Eads wrote: > > > > +#define STACK_F_NB 0x0001 > > > > > > What about adding the RTE_ prefix? > > > > I'm fine with either, but there's precedent for flag macros named > > _*. E.g. RING_F_*, MEMPOOL_F_*, ETH_*, and > SERVICE_F_*. >=20 > They should be fixed. > Every public symbols should be prefixed to avoid namespace conflict. > At first, we should rename them and keep the old name as an alias. > Later, non-prefixed names should be removed after a deprecation notice. >=20 Ok, will fix. Thanks, Gage =09