From: "Eads, Gage" <gage.eads@intel.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
nd <nd@arm.com>,
"chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] eal: add 128-bit cmpxchg (x86-64 only)
Date: Mon, 4 Mar 2019 20:47:04 +0000 [thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E541F1710@FMSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <AM6PR08MB36722DD953E52813A3DD279898710@AM6PR08MB3672.eurprd08.prod.outlook.com>
[snip]
> > +/**
> > + * An atomic compare and set function used by the mutex functions.
> > + * (Atomically) Equivalent to:
> > + * if (*dst == exp)
> Should be, "if (*dst == *exp)"
>
> > + * *dst = src
> Should be "*dst = *src"
>
Good catches, will fix both.
> > + * else
> > + * *exp = *dst
> > + *
> > + * @note The success and failure arguments must be one of the
> > +__ATOMIC_* values
> > + * defined in the C++11 standard. For details on their behavior,
> > +refer to the
> > + * standard.
> > + *
> > + * @param dst
> > + * The destination into which the value will be written.
> > + * @param exp
> > + * Pointer to the expected value. If the operation fails, this memory is
> > + * updated with the actual value.
> > + * @param src
> > + * Pointer to the new value.
> > + * @param weak
> > + * A value of true allows the comparison to spuriously fail and allows the
> > + * 'exp' update to occur non-atomically (i.e. a torn read may occur).
> > + * Implementations may ignore this argument and only implement the
> strong
> > + * variant.
> > + * @param success
> > + * If successful, the operation's memory behavior conforms to this (or a
> > + * stronger) model.
> > + * @param failure
> > + * If unsuccessful, the operation's memory behavior conforms to this (or a
> > + * stronger) model. This argument cannot be __ATOMIC_RELEASE,
> > + * __ATOMIC_ACQ_REL, or a stronger model than success.
> > + * @return
> > + * Non-zero on success; 0 on failure.
> > + */
> > +static inline int __rte_experimental
> > +rte_atomic128_cmpxchg(rte_int128_t *dst,
> Name could be more neutral. May be rte_atomic128_compare/cmp_exchange?
>
> > + rte_int128_t *exp,
> > + const rte_int128_t *src,
> > + unsigned int weak,
> > + int success,
> > + int failure);
> > +#endif
> > +
> > #endif /* _RTE_ATOMIC_H_ */
> > --
> > 2.13.6
>
Sure -- I'll rename it rte_atomic128_cmp_exchange in the next version.
> Few minor comments.
> I have not reviewed the x86 implementation.
> Otherwise,
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Thanks,
Gage
next prev parent reply other threads:[~2019-03-04 20:47 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 17:29 [dpdk-dev] [PATCH 0/1] Add 128-bit compare and set Gage Eads
2019-01-28 17:29 ` [dpdk-dev] [PATCH 1/1] eal: add 128-bit cmpset (x86-64 only) Gage Eads
2019-01-28 23:01 ` Ola Liljedahl
2019-02-01 17:06 ` Eads, Gage
2019-02-01 19:01 ` Ola Liljedahl
2019-02-01 19:28 ` Eads, Gage
2019-02-01 19:43 ` Ola Liljedahl
2019-02-01 21:05 ` Eads, Gage
2019-02-01 23:11 ` Ola Liljedahl
2019-02-04 18:33 ` Honnappa Nagarahalli
2019-01-31 5:48 ` Honnappa Nagarahalli
2019-02-01 17:11 ` Eads, Gage
2019-02-22 15:46 ` [dpdk-dev] [PATCH v2 0/1] Add 128-bit compare and set Gage Eads
2019-02-22 15:46 ` [dpdk-dev] [PATCH v2 1/1] eal: add 128-bit cmpxchg (x86-64 only) Gage Eads
2019-03-04 20:19 ` Honnappa Nagarahalli
2019-03-04 20:47 ` Eads, Gage [this message]
2019-03-04 20:51 ` [dpdk-dev] [PATCH v3 0/1] Add 128-bit compare and set Gage Eads
2019-03-04 20:51 ` [dpdk-dev] [PATCH v3 1/1] eal: add 128-bit compare exchange (x86-64 only) Gage Eads
2019-03-27 23:12 ` Thomas Monjalon
2019-03-27 23:12 ` Thomas Monjalon
2019-03-28 16:22 ` Eads, Gage
2019-03-28 16:22 ` Eads, Gage
2019-04-03 17:34 ` [dpdk-dev] [PATCH v4 0/1] Add 128-bit compare and set Gage Eads
2019-04-03 17:34 ` Gage Eads
2019-04-03 17:34 ` [dpdk-dev] [PATCH v4 1/1] eal: add 128-bit compare exchange (x86-64 only) Gage Eads
2019-04-03 17:34 ` Gage Eads
2019-04-03 19:04 ` Thomas Monjalon
2019-04-03 19:04 ` Thomas Monjalon
2019-04-03 19:21 ` Eads, Gage
2019-04-03 19:21 ` Eads, Gage
2019-04-03 19:27 ` Thomas Monjalon
2019-04-03 19:27 ` Thomas Monjalon
2019-04-03 19:35 ` [dpdk-dev] [PATCH v5] eal/x86: add 128-bit atomic compare exchange Thomas Monjalon
2019-04-03 19:35 ` Thomas Monjalon
2019-04-03 19:44 ` [dpdk-dev] [PATCH v6] " Gage Eads
2019-04-03 19:44 ` Gage Eads
2019-04-03 20:01 ` Thomas Monjalon
2019-04-03 20:01 ` Thomas Monjalon
2019-04-04 11:47 ` Ferruh Yigit
2019-04-04 11:47 ` Ferruh Yigit
2019-04-04 12:08 ` Thomas Monjalon
2019-04-04 12:08 ` Thomas Monjalon
2019-04-04 12:12 ` Thomas Monjalon
2019-04-04 12:12 ` Thomas Monjalon
2019-04-04 12:14 ` Eads, Gage
2019-04-04 12:14 ` Eads, Gage
2019-04-04 12:18 ` Thomas Monjalon
2019-04-04 12:18 ` Thomas Monjalon
2019-04-04 12:22 ` Eads, Gage
2019-04-04 12:22 ` Eads, Gage
2019-04-04 12:24 ` Eads, Gage
2019-04-04 12:24 ` Eads, Gage
2019-04-04 12:52 ` Ferruh Yigit
2019-04-04 12:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9184057F7FC11744A2107296B6B8EB1E541F1710@FMSMSX108.amr.corp.intel.com \
--to=gage.eads@intel.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).