From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3986E1B4DE for ; Wed, 3 Apr 2019 19:13:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 10:13:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,305,1549958400"; d="scan'208";a="220251362" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 03 Apr 2019 10:13:51 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 10:13:51 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.216]) by FMSMSX112.amr.corp.intel.com ([169.254.5.23]) with mapi id 14.03.0415.000; Wed, 3 Apr 2019 10:13:51 -0700 From: "Eads, Gage" To: Thomas Monjalon CC: "dev@dpdk.org" , Honnappa Nagarahalli , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "Richardson, Bruce" , "Ananyev, Konstantin" , "Gavin Hu (Arm Technology China)" , nd Thread-Topic: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library Thread-Index: AQHU6NAAuuD+CTYsm0yfTSRX0ngoyaYouHdAgAJqZAD//4vm8A== Date: Wed, 3 Apr 2019 17:13:50 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E5421054F@FMSMSX108.amr.corp.intel.com> References: <20190401001238.17625-1-gage.eads@intel.com> <20190401211429.20282-2-gage.eads@intel.com> <5912114.tna7mvfDTn@xps> In-Reply-To: <5912114.tna7mvfDTn@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjllZGY4MTktNTFlYi00NTU3LTgzZDEtNTAzYzU1MjdjYjM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWFdKS212dDdhVGJzeHN1bHRNcHRuK2ZOaVFzdGZ5Q1o1YW9WM20weFpGdzMzaGtUZnBaOWhwcHEwTnhqQ1FmeiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 17:13:53 -0000 > 02/04/2019 13:14, Honnappa Nagarahalli: > > > Subject: [PATCH v6 1/8] stack: introduce rte stack library > > > > > > The rte_stack library provides an API for configuration and use of a > > > bounded stack of pointers. Push and pop operations are MT-safe, > > > allowing concurrent access, and the interface supports pushing and > > > popping multiple pointers at a time. > > > > > > The library's interface is modeled after another DPDK data > > > structure, rte_ring, and its lock-based implementation is derived > > > from the stack mempool handler. An upcoming commit will migrate the > > > stack mempool handler to rte_stack. > > > > > > Signed-off-by: Gage Eads > > > Reviewed-by: Olivier Matz > > > --- > > Reviewed-by: Honnappa Nagarahalli >=20 > It does not compile for Arm: >=20 > lib/librte_stack/rte_stack_std.h: > In function '__rte_stack_std_pop': > lib/librte_stack/rte_stack_std.h:68:6: error: > implicit declaration of function 'unlikely' Missing rte_branch_prediction.h include -- I'll fix and resubmit. Thanks fo= r checking the non-x86 builds. I can hold off resubmission until the 128-bit CAS patch is merged, so this = series is properly tested in the automated build + test pipeline, if you'd = prefer. Thanks, Gage From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6200EA0679 for ; Wed, 3 Apr 2019 19:13:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 736BD1B4ED; Wed, 3 Apr 2019 19:13:54 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3986E1B4DE for ; Wed, 3 Apr 2019 19:13:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 10:13:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,305,1549958400"; d="scan'208";a="220251362" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 03 Apr 2019 10:13:51 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 10:13:51 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.216]) by FMSMSX112.amr.corp.intel.com ([169.254.5.23]) with mapi id 14.03.0415.000; Wed, 3 Apr 2019 10:13:51 -0700 From: "Eads, Gage" To: Thomas Monjalon CC: "dev@dpdk.org" , Honnappa Nagarahalli , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "Richardson, Bruce" , "Ananyev, Konstantin" , "Gavin Hu (Arm Technology China)" , nd Thread-Topic: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library Thread-Index: AQHU6NAAuuD+CTYsm0yfTSRX0ngoyaYouHdAgAJqZAD//4vm8A== Date: Wed, 3 Apr 2019 17:13:50 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E5421054F@FMSMSX108.amr.corp.intel.com> References: <20190401001238.17625-1-gage.eads@intel.com> <20190401211429.20282-2-gage.eads@intel.com> <5912114.tna7mvfDTn@xps> In-Reply-To: <5912114.tna7mvfDTn@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjllZGY4MTktNTFlYi00NTU3LTgzZDEtNTAzYzU1MjdjYjM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWFdKS212dDdhVGJzeHN1bHRNcHRuK2ZOaVFzdGZ5Q1o1YW9WM20weFpGdzMzaGtUZnBaOWhwcHEwTnhqQ1FmeiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/8] stack: introduce rte stack library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403171350.x3xE7mLKPuMJtFKSw9bkTcZbNxfFnoqfhaOcyZl_jGg@z> > 02/04/2019 13:14, Honnappa Nagarahalli: > > > Subject: [PATCH v6 1/8] stack: introduce rte stack library > > > > > > The rte_stack library provides an API for configuration and use of a > > > bounded stack of pointers. Push and pop operations are MT-safe, > > > allowing concurrent access, and the interface supports pushing and > > > popping multiple pointers at a time. > > > > > > The library's interface is modeled after another DPDK data > > > structure, rte_ring, and its lock-based implementation is derived > > > from the stack mempool handler. An upcoming commit will migrate the > > > stack mempool handler to rte_stack. > > > > > > Signed-off-by: Gage Eads > > > Reviewed-by: Olivier Matz > > > --- > > Reviewed-by: Honnappa Nagarahalli >=20 > It does not compile for Arm: >=20 > lib/librte_stack/rte_stack_std.h: > In function '__rte_stack_std_pop': > lib/librte_stack/rte_stack_std.h:68:6: error: > implicit declaration of function 'unlikely' Missing rte_branch_prediction.h include -- I'll fix and resubmit. Thanks fo= r checking the non-x86 builds. I can hold off resubmission until the 128-bit CAS patch is merged, so this = series is properly tested in the automated build + test pipeline, if you'd = prefer. Thanks, Gage