DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Mempool handler ops index allocation issue
@ 2019-05-09 22:19 Eads, Gage
  2019-05-09 22:19 ` Eads, Gage
  2019-05-13 12:14 ` Olivier Matz
  0 siblings, 2 replies; 7+ messages in thread
From: Eads, Gage @ 2019-05-09 22:19 UTC (permalink / raw)
  To: dev; +Cc: olivier.matz, arybchenko

Hi all,

I ran into a problem with a multi-process application, in which two processes assigned the same mempool handler ops index to *different* handlers. This happened because the two processes supplied the -d EAL arguments in different order, e.g.:

sudo ./appA -dlibrte_mempool_bucket.so -dlibrte_mempool_ring.so --proc-type primary &
sudo ./appB -dlibrte_mempool_ring.so -dlibrte_mempool_bucket.so --proc-type secondary &

The dynamic load order matters because the ops indexes are assigned in the order the library ctors are run. This can result in the different processes trying to use different handlers for the same mempool.

I'm not aware of any requirement that the EAL argument order should match across processes, so I don't think this is a user error. This could also happen in static libraries if they linked the libraries in a different order - but that shouldn't occur if both applications are following the rules for building an external application (https://doc.dpdk.org/guides/prog_guide/dev_kit_build_system.html#building-external-applications).

If you agree that this is an issue, I see a couple possible resolutions:


1.       Add a note/warning to the mempool handlers section of the user guide (https://doc.dpdk.org/guides/prog_guide/mempool_lib.html#mempool-handlers)

2.       Modify rte_mempool_register_ops() so that built-in handlers (ring, stack, etc.) have fixed IDs. E.g. ring is always 0, stack is always 1, etc. These handlers could be identified by their name string. User-registered mempools would still be susceptible to this problem, though.

Thoughts? Alternatives?

Thanks,
Gage

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-06-18 18:14 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-09 22:19 [dpdk-dev] Mempool handler ops index allocation issue Eads, Gage
2019-05-09 22:19 ` Eads, Gage
2019-05-13 12:14 ` Olivier Matz
2019-05-13 12:14   ` Olivier Matz
2019-05-13 12:22   ` [dpdk-dev] ***Spam*** " Andrew Rybchenko
2019-05-13 12:22     ` Andrew Rybchenko
2019-06-18 18:14     ` Eads, Gage

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).