From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0EE0FA0471 for ; Thu, 20 Jun 2019 20:39:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7BD941D452; Thu, 20 Jun 2019 20:39:46 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C87631D44F for ; Thu, 20 Jun 2019 20:39:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 11:39:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,397,1557212400"; d="scan'208";a="335586945" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 20 Jun 2019 11:39:43 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Jun 2019 11:39:43 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.149]) by fmsmsx111.amr.corp.intel.com ([169.254.12.238]) with mapi id 14.03.0439.000; Thu, 20 Jun 2019 11:39:27 -0700 From: "Eads, Gage" To: Aaron Conole CC: "dev@dpdk.org" , "jerinj@marvell.com" , "Van Haaren, Harry" , "Rao, Nikhil" , "Carrillo, Erik G" , "nhorman@tuxdriver.com" , "Richardson, Bruce" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH] eal: promote some service core functions to stable Thread-Index: AQHVJ5WwHwCwmTzeQUyDrfiyCmNQmaak3Pyw Date: Thu, 20 Jun 2019 18:39:27 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E68CFF91C@FMSMSX108.amr.corp.intel.com> References: <20190620164206.3972-1-gage.eads@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWRjNzQyMTQtNDMyZC00MzcxLWI5ZGEtNjhkNDUwZjcyOTgzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOEcwWkRMS0p3Zkk0ZmZPUHhLSlNpbTdDZEN2YThJZWsydVR2UjVGY2cyeGRIMXRiZzBUa1h1OEljUzdvY2hQQiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal: promote some service core functions to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Gage Eads writes: >=20 > > The functions rte_service_may_be_active(), > > rte_service_lcore_attr_get(), and rte_service_attr_reset_all() were > > introduced nearly a year ago in DPDK 18.08. They can be considered non- > experimental for the 19.08 release. > > > > rte_service_may_be_active() is used by eventdev and the sw PMD, and > > this commit allows them to not need any experimental API. > > > > Signed-off-by: Gage Eads > > --- > > drivers/event/sw/Makefile | 1 - > > drivers/event/sw/meson.build | 1 - > > lib/librte_eal/common/include/rte_service.h | 15 +++------------ > > lib/librte_eal/common/rte_service.c | 6 +++--- > > lib/librte_eal/rte_eal_version.map | 6 +++--- > > lib/librte_eventdev/Makefile | 1 - > > lib/librte_eventdev/meson.build | 1 - > > 7 files changed, 9 insertions(+), 22 deletions(-) > > > > diff --git a/drivers/event/sw/Makefile b/drivers/event/sw/Makefile > > index 81236a392..c6600e836 100644 > > --- a/drivers/event/sw/Makefile > > +++ b/drivers/event/sw/Makefile > > @@ -7,7 +7,6 @@ include $(RTE_SDK)/mk/rte.vars.mk LIB =3D > > librte_pmd_sw_event.a > > > > # build flags > > -CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > > CFLAGS +=3D -O3 > > CFLAGS +=3D $(WERROR_FLAGS) > > # for older GCC versions, allow us to initialize an event using diff > > --git a/drivers/event/sw/meson.build b/drivers/event/sw/meson.build > > index 30d221647..985012219 100644 > > --- a/drivers/event/sw/meson.build > > +++ b/drivers/event/sw/meson.build > > @@ -1,7 +1,6 @@ > > # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel > > Corporation > > > > -allow_experimental_apis =3D true >=20 > I don't think you can remove these. There are still some experimental AP= Is > (f.e. the rename for rte_cryptodev_sym_session_get_private_data > marked that function as experimental and it will cause build breakage). >=20 > Maybe I'm mis understanding it? It would be good to get verification fro= m > Bruce whether that API should not be marked as experimental (it was just = a > rename, so not sure...) - maybe that's a follow up for this patch? >=20 > See: https://travis-ci.com/ovsrobot/dpdk/jobs/209722145 for an example >=20 > The odd thing is I only see it on the clang builds - perhaps it's a missi= ng > definition for the clang compiler. >=20 You're right, eventdev still uses that experimental API (which this patch i= s unrelated to). I tested this change with GCC (5.4.0) and it built without= errors, which I took to mean no more experimental APIs were in use. That's= concerning that GCC didn't catch it. At any rate, I'll correct this in v2. Thanks, Gage