From: "Eads, Gage" <gage.eads@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [dpdk-dev] [PATCH] service: improve service run performance
Date: Mon, 7 Oct 2019 14:52:35 +0000 [thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E6EE781C9@FMSMSX108.amr.corp.intel.com> (raw)
> For a valid service, the core mask of the service
> is checked against the current core and the corresponding
> entry in the active_on_lcore array is set or reset.
> Upto 8 cores share the same cache line for their
> service active_on_lcore array entries since each entry is a uint8_t.
> Some number of these entries also share the cache line with
> the internal_flags member of struct rte_service_spec_impl,
> hence this false sharing also makes the service_valid() check
> expensive.
> Eliminate false sharing by moving the active_on_lcore array to
> a per-core data structure. The array is now indexed by service id.
> Signed-off-by: Nikhil Rao <nikhil.rao at intel.com>
Acked-by: Gage Eads <gage.eads@intel.com>
Thanks,
Gage
next reply other threads:[~2019-10-07 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 14:52 Eads, Gage [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-16 10:01 Nikhil Rao
2019-10-07 14:52 ` David Marchand
2019-10-07 15:37 ` Van Haaren, Harry
2019-10-18 4:10 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9184057F7FC11744A2107296B6B8EB1E6EE781C9@FMSMSX108.amr.corp.intel.com \
--to=gage.eads@intel.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).