From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7686DA2EEB for ; Mon, 7 Oct 2019 16:52:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABBFC1C1D2; Mon, 7 Oct 2019 16:52:38 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DF3991C1A8 for ; Mon, 7 Oct 2019 16:52:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 07:52:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,268,1566889200"; d="scan'208";a="368135822" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 07 Oct 2019 07:52:35 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 07:52:35 -0700 Received: from fmsmsx108.amr.corp.intel.com ([169.254.9.101]) by fmsmsx156.amr.corp.intel.com ([169.254.13.247]) with mapi id 14.03.0439.000; Mon, 7 Oct 2019 07:52:35 -0700 From: "Eads, Gage" To: "dev@dpdk.org" CC: "Rao, Nikhil" Thread-Topic: Re: [dpdk-dev] [PATCH] service: improve service run performance Thread-Index: AdV9HkhY/6UQ2GBZSjaHXvsWLBoTtA== Date: Mon, 7 Oct 2019 14:52:35 +0000 Message-ID: <9184057F7FC11744A2107296B6B8EB1E6EE781C9@FMSMSX108.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWNjZjEyNTEtYzVjNC00NTA1LWJiYTgtYmUzY2QwYmNmNGQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK1JrS1NkSmE0c25xN1wvc3ZHdHdBN252a2czcW9qRXJKMEhqOTkwR0NJeHY3WnlUcWhxeHFKTk9MSTJXSk02VDMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] service: improve service run performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > For a valid service, the core mask of the service > is checked against the current core and the corresponding > entry in the active_on_lcore array is set or reset. > Upto 8 cores share the same cache line for their > service active_on_lcore array entries since each entry is a uint8_t. > Some number of these entries also share the cache line with > the internal_flags member of struct rte_service_spec_impl, > hence this false sharing also makes the service_valid() check > expensive. > Eliminate false sharing by moving the active_on_lcore array to > a per-core data structure. The array is now indexed by service id. > Signed-off-by: Nikhil Rao Acked-by: Gage Eads Thanks, Gage