From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 8E34C4AAD for ; Fri, 22 Jul 2016 10:21:36 +0200 (CEST) Received: by mail-lf0-f46.google.com with SMTP id l69so79723348lfg.1 for ; Fri, 22 Jul 2016 01:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=LSS7dVSVOmerM2idQFMVSGcTryfI7WaDQNbU6iL90dk=; b=F+ARIi7S187EysfOXy+ZjiMXW3a+ZRCd6znmNaO6pO01haEhR4QH1pBdtwJTWmTl9K NP9pgSF/waLVWdIJO8GnYIAJrIXwoYkgZLAZS0Sotye11b58bHhqtonHOTDyFQ9c/ind yDeSpH4tFzLrCCF0U5EI4yUjBkfKFga3U51rb9HOWt1KZ63eFxS/NZvc8ou/q/zrlxia cPwHOhzOSlzYS3k4Kdue4v8RXhN1Zrz/lGfZHU6jGiDI34M63WCrKr90zBhcJdHsZ6de 205N4mo8iDc5cBy5QOGJv7c6JePGJighH+49Mrs+gVJDLC+u1jVZeqcPTFQYPIFodG8X /yRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=LSS7dVSVOmerM2idQFMVSGcTryfI7WaDQNbU6iL90dk=; b=iuckshv5yzL2PHwpPLchmZBuExUTs+g1pBxlEenrV8jH4aitXCQ/pucrSzSZwRKTyp 1bGw7LpuxAkAXeO/EG6SbTKwreitV3WtLBQyqaFKkQ6tRsX4RPnavu17vTQUPMRyrG6i 15QnLhKvflAIIBPGM+KoN3j8OgVRYIKZ3mHHA1eeSRr0gfwcXgkVlipVttoI1fMSeUk3 sFVWkPnh2o+PYLEcm05pp5rnWsHz406Q7ZTY/YSEY7NblV4O/4c0KsBmHfIt3Gjgx+xq Vja8nS08VkKzil7XE+jE6Y69jYgh6ojLDvqCp8KYuLWBnHN4Q0n+py1qDYUhWTs9sD6m D+DQ== X-Gm-Message-State: AEkoousBc5o9mN66NGPr0rv7vbvkDsUKh+iLHojGwSTmjPx0JHy5dtQxbfpHnLm+BO1Tx1AW X-Received: by 10.46.33.217 with SMTP id h86mr1949720lji.39.1469175696210; Fri, 22 Jul 2016 01:21:36 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id f139sm2716854lfb.11.2016.07.22.01.21.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jul 2016 01:21:35 -0700 (PDT) From: Thomas Monjalon To: "Chen, Jing D" Cc: dev@dpdk.org, "Wang, Xiao W" , "Lin, Xueqin" Date: Fri, 22 Jul 2016 10:21:34 +0200 Message-ID: <91849256.XuHjXYpFvk@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1469089470-5764-1-git-send-email-xiao.w.wang@intel.com> <4341B239C0EFF9468EE453F9E9F4604D044DECE4@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 08:21:36 -0000 2016-07-21 09:35, Wang, Xiao W: > From: Chen, Jing D > > > --- a/drivers/net/fm10k/fm10k_ethdev.c > > > +++ b/drivers/net/fm10k/fm10k_ethdev.c > > > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev, > > > > > > PMD_INIT_FUNC_TRACE(); > > > > > > - if (rss_conf->rss_key_len < FM10K_RSSRK_SIZE * > > > - FM10K_RSSRK_ENTRIES_PER_REG) > > > + if (key && (rss_conf->rss_key_len < FM10K_RSSRK_SIZE * > > > + FM10K_RSSRK_ENTRIES_PER_REG)) > > > return -EINVAL; > > > > > > if (hf == 0) > > > > It's also possible that app wants to update rss key and not expect to update hash > > function. > > Is that indicate we shouldn't return error in case hf == 0? > > > > If the app just wants to update RSS key, it needs to read out the RSS config first, then > change only the key field. This is what testpmd does for this operation. > > hf == 0 will disable RSS feature, I think we should return error to protect multi-queue. Jing, do you confirm we can apply this patch, please?