From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id EDFAAB5BE for ; Fri, 20 Feb 2015 13:16:09 +0100 (CET) Received: by mail-wi0-f178.google.com with SMTP id em10so2487059wid.5 for ; Fri, 20 Feb 2015 04:16:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=lumtt0jjnxpE3LmFxjRkQz7w4AltojLylfPE7t97IdI=; b=BlQiowWLawUbHifX5aE1YIQF29a81ch+kTc2uzlF/YaGM4JSNjbm3expIflnVWZVqn rbsJelYdbaJF3G7BWf3vdIyG2UixdnBadHk+0fC4daQ1nvOhzA2Z40jGkOGMSbsZnhmu XBb/Ok1Hpog9LFSm6QvKGZyDsOOovUEn7Ub83YgRyJjgkRKR8pHEO6DdipfE0Ft2Llar KNsef7ltlckgtFWJ0+6BPtZTcsVpMOMYEW1c23qTzVFuQ1yQdZHdr0Yap2h/d0XXCebJ P/SApDORdDKMaVM7+5lPyFCKjewnWy2Y7ZqgG1EV+L9IiHeeHXRXwZy7s8cu1iBaTCTE 3fbA== X-Gm-Message-State: ALoCoQk1mG8CC8Ypmeo+pJWqb/SIJSN4naiaCpvfgnQinShDyrmsgTW5fXRBANF0sddtUruo3GYn X-Received: by 10.180.86.35 with SMTP id m3mr5082981wiz.83.1424434569765; Fri, 20 Feb 2015 04:16:09 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id a1sm2138459wiy.10.2015.02.20.04.16.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 04:16:08 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Fri, 20 Feb 2015 13:15:38 +0100 Message-ID: <9190554.3JBlDK3N1R@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <65cbd71d3b5b45f469a2fe67fe8b0def4bddebbd.1423754231.git.pmatilai@redhat.com> References: <54DCB16F.7080104@redhat.com> <65cbd71d3b5b45f469a2fe67fe8b0def4bddebbd.1423754231.git.pmatilai@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] mk: Only default to -Werror when building from git checkout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 12:16:10 -0000 2015-02-12 17:18, Panu Matilainen: > Add RTE_DEVEL_BUILD make-variable which can be used to do things > differently when doing development vs building a release, > autodetected from source root .git presence and overridable via > commandline. Use it to only enable -Werror compiler flag when > building a git checkout: > > Failing build on warnings is a useful developer tool but its bad > for release tarballs which can and do get built with newer > compilers than what was used/available during development. Compilers > routinely add new warnings so code which built silently with cc X > might no longer do so with X+1. This doesn't make the existing code > any more buggier and failing the build in this case does not help > not help improve code quality of an already released version either. Please, could you update documentation to explain RTE_DEVEL_BUILD option? Some users could try to build from git, so we should advise to disable RTE_DEVEL_BUILD. These files might be updated: http://dpdk.org/browse/dpdk/tree/doc/build-sdk-quick.txt http://dpdk.org/browse/dpdk/tree/doc/guides/linux_gsg/build_dpdk.rst http://dpdk.org/browse/dpdk/tree/doc/guides/freebsd_gsg/build_dpdk.rst http://dpdk.org/browse/dpdk/tree/doc/guides/prog_guide/dev_kit_build_system.rst Thanks