From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CA7971B19B for ; Fri, 6 Oct 2017 03:13:18 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2017 18:13:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,482,1500966000"; d="scan'208";a="907236876" Received: from unknown (HELO [10.241.225.33]) ([10.241.225.33]) by FMSMGA003.fm.intel.com with ESMTP; 05 Oct 2017 18:13:14 -0700 To: Adrien Mazarguil , Gaetan Rivet Cc: dev@dpdk.org References: From: Ferruh Yigit Message-ID: <919ab2dc-1081-d139-50a3-c797fbeb7284@intel.com> Date: Fri, 6 Oct 2017 02:13:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 0/7] Flow API helpers enhancements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 01:13:19 -0000 On 10/5/2017 10:49 AM, Adrien Mazarguil wrote: > This series brings enhancements to various rte_flow helpers: > > - Allow applications to use rte_flow_error_set() by making it part of the > public interface and documenting it as such. > > - Address rte_flow_copy()'s limitations by replacing it with the more > versatile rte_flow_conv(). This new function allows retrieving other > properties such as item/action names, enabling testpmd to finally use it > and get rid of duplicated code. > > - Add a script (gen-rte_flow_conv-h.sh) to help with generating the > resources used by rte_flow_conv(). Developers should run it when adding or > modifying pattern items or actions (done as part of this series to add the > missing "fuzzy" pattern item). > > - Future plans for rte_flow_conv() include translating error codes to > human-readable messages, so applications do not have to make their own. > > All these changes address concerns raised a couple of months ago [1]. Work > on these patches actually started at the time but I was unable to complete > and clean them up until recently. > > [1] http://dpdk.org/ml/archives/dev/2017-July/070492.html > > Adrien Mazarguil (7): > ethdev: expose flow API error helper > ethdev: replace flow API object copy function > ethdev: add flow API item/action name conversion > app/testpmd: rely on flow API conversion function > ethdev: enhance flow API item/action descriptions > ethdev: generate flow API conversion header > ethdev: update flow API conversion header Hi Adrien, This received too late for this release cycle, and changes in rte_flow library may effect PMDs. I suggest deferring the set to next release, what do you think? Thanks, ferruh