From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC815A0524; Mon, 27 Jul 2020 06:08:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 09BBF1C025; Mon, 27 Jul 2020 06:07:59 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 447171C023 for ; Mon, 27 Jul 2020 06:07:56 +0200 (CEST) IronPort-SDR: AptMjiOVRQw3lvQusTE5r9/4AwRDocKQGMW7R0yDYfBO5T6ZXqKzIP3EfEVkd0jHgGfqX2AzPf 4bh7RQfh+1CA== X-IronPort-AV: E=McAfee;i="6000,8403,9694"; a="150932617" X-IronPort-AV: E=Sophos;i="5.75,401,1589266800"; d="scan'208";a="150932617" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2020 21:07:55 -0700 IronPort-SDR: FwB2GyLNilWrMORjE9uTQEXAxaEZuPptDXQ/1TKlPW/LuJbzOkNXDXJIDOeOdoYSijTe3CFYaS JxWczU1LWz/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,401,1589266800"; d="scan'208";a="327892120" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.176]) ([10.67.68.176]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jul 2020 21:07:53 -0700 To: Guinan Sun , dev@dpdk.org Cc: Beilei Xing , Adam Ludkiewicz References: <20200721074000.30449-1-guinanx.sun@intel.com> <20200721074000.30449-6-guinanx.sun@intel.com> From: Jeff Guo Message-ID: <91ae8060-d020-734b-d50d-0e688b0564bb@intel.com> Date: Mon, 27 Jul 2020 12:07:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200721074000.30449-6-guinanx.sun@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 5/8] net/i40e/base: check return value of DNL admin command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, guinan On 7/21/2020 3:39 PM, Guinan Sun wrote: > Check return value of running DNL admin command. What is "DNL", I am not sure i know the reason it appear here, could you double check it? > > Signed-off-by: Adam Ludkiewicz > Signed-off-by: Guinan Sun > --- > drivers/net/i40e/base/i40e_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c > index 46a0b7881..85c22849e 100644 > --- a/drivers/net/i40e/base/i40e_common.c > +++ b/drivers/net/i40e/base/i40e_common.c > @@ -7097,7 +7097,7 @@ enum i40e_status_code i40e_get_lpi_counters(struct i40e_hw *hw, > I40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT, > &cmd_status, tx_counter, rx_counter, NULL); > > - if (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC) > + if (!retval && cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC) > retval = I40E_ERR_ADMIN_QUEUE_ERROR; > > return retval;