Re: [dpdk-dev] [PATCH] net/i40e: fix missing Port Representor data-path callbacks

[Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>]

On 09/05/2018 16:00, Remy Horton wrote:
> This patch adds Rx and Tx burst functions to the i40e Port
> Representors, so that the implementation within this PMD
> can be tested using applications such as testpmd which
> require data-path functionality.
>
> Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
>
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
>   drivers/net/i40e/i40e_vf_representor.c | 27 ++++++++++++++++++++++++---
>   1 file changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_vf_representor.c b/drivers/net/i40e/i40e_vf_representor.c
> index 96b3787..e205019 100644
> --- a/drivers/net/i40e/i40e_vf_representor.c
> +++ b/drivers/net/i40e/i40e_vf_representor.c
> @@ -337,6 +337,25 @@ struct eth_dev_ops i40e_representor_dev_ops = {
>   
>   };
>   
> +static uint16_t
> +i40e_vf_representor_rx_burst(__rte_unused void *rx_queue,
> +	__rte_unused struct rte_mbuf **rx_pkts, __rte_unused uint16_t nb_pkts)
> +{
> +	return 0;
> +}
> +
> +static uint16_t
> +i40e_vf_representor_tx_burst(__rte_unused void *tx_queue,
> +	struct rte_mbuf **tx_pkts,
> +	uint16_t nb_pkts)
> +{
> +	uint16_t idx_pkt;
> +
> +	for (idx_pkt = 0; idx_pkt < nb_pkts; idx_pkt++)
> +		rte_pktmbuf_free(tx_pkts[idx_pkt]);
We should not free them in the driver silently whereas the application 
will think that it has been sent successfully.
Please use the same rule for rx_burst, and return 0.
> +	return nb_pkts;
> +}
> +
>   int
>   i40e_vf_representor_init(struct rte_eth_dev *ethdev, void *init_params)
>   {
> @@ -365,9 +384,11 @@ i40e_vf_representor_init(struct rte_eth_dev *ethdev, void *init_params)
>   	/* Set representor device ops */
>   	ethdev->dev_ops = &i40e_representor_dev_ops;
>   
> -	/* No data-path so no RX/TX functions */
> -	ethdev->rx_pkt_burst = NULL;
> -	ethdev->tx_pkt_burst = NULL;
> +	/* No data-path, but need stub Rx/Tx functions to avoid crash
> +	 * when testing with the likes of testpmd.
> +	 */
> +	ethdev->rx_pkt_burst = i40e_vf_representor_rx_burst;
> +	ethdev->tx_pkt_burst = i40e_vf_representor_tx_burst;
>   
>   	vf = &pf->vfs[representor->vf_id];
>