From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2132A9E3 for ; Tue, 19 Jul 2016 07:31:41 +0200 (CEST) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 12DDBC057EC7; Tue, 19 Jul 2016 05:31:40 +0000 (UTC) Received: from [10.36.4.31] (vpn1-4-31.ams2.redhat.com [10.36.4.31]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6J5Vax2012646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Jul 2016 01:31:38 -0400 To: Yuanhan Liu References: <1468861764-22197-1-git-send-email-maxime.coquelin@redhat.com> <20160719013934.GI5146@yliu-dev.sh.intel.com> Cc: huawei.xie@intel.com, dev@dpdk.org, Thomas Monjalon From: Maxime Coquelin Message-ID: <91d5b0a9-fbc6-ece4-f4cb-f3cb8eb27c3d@redhat.com> Date: Tue, 19 Jul 2016 07:31:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160719013934.GI5146@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 19 Jul 2016 05:31:40 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net: virtio: clear reserved vring properly at setup time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 05:31:41 -0000 On 07/19/2016 03:39 AM, Yuanhan Liu wrote: > On Mon, Jul 18, 2016 at 07:09:24PM +0200, Maxime Coquelin wrote: >> After vring reservation, only the first bytes of the vring were >> cleared. >> >> This patch fixes this to clear the real size fo the vring. >> >> Signed-off-by: Maxime Coquelin >> --- >> >> Note: I found this bug while doing some code review, > > Nice catch! > >> it is not a fix for >> a problem I encountered. > > Yes, there should be no problem: vring memory is completely zero-ed > at port start stage by virtio_dev_vring_start(). Ok, thanks for the pointer. > >> --- >> drivers/net/virtio/virtio_ethdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >> index 850e3ba..336b3fc 100644 >> --- a/drivers/net/virtio/virtio_ethdev.c >> +++ b/drivers/net/virtio/virtio_ethdev.c >> @@ -387,7 +387,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, >> } >> } >> >> - memset(mz->addr, 0, sizeof(mz->len)); >> + memset(mz->addr, 0, mz->len); > > Actually, I think we could simply drop the memset here. It's redundant, > as stated. We can skip this patch then. > > And to Thomas, I don't find a good reason to have this in 16.07. Let's > delay the apply to v16.11. Yes, that's why I mentioned it didn't fixed any problem on my side. So I propose we skip this patch, I'll resend one removing the memset for v16.11. Thanks, Maxime > > --yliu > >> vq->vq_ring_mem = mz->phys_addr; >> vq->vq_ring_virt_mem = mz->addr; >> -- >> 2.7.4