Re: [dpdk-dev] [PATCH v1 1/3] ethdev: remove detachable device flag

[Andrew Rybchenko <arybchenko@solarflare.com>]

On 10/24/2017 11:59 AM, Gaetan Rivet wrote:
> This flag is not necessary at the ether layer anymore.
> Buses are able to advertize their hotplug support. The ether layer can
> rely upon this capability instead of a special flag.
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

> ---
>   drivers/net/af_packet/rte_eth_af_packet.c |  1 -
>   drivers/net/ark/ark_ethdev.c              |  1 -
>   drivers/net/avp/avp_ethdev.c              |  2 --
>   drivers/net/bnxt/bnxt_ethdev.c            |  1 -
>   drivers/net/bonding/rte_eth_bond_pmd.c    |  3 +--
>   drivers/net/e1000/em_ethdev.c             |  1 -
>   drivers/net/e1000/igb_ethdev.c            |  2 --
>   drivers/net/fm10k/fm10k_ethdev.c          |  1 -
>   drivers/net/i40e/i40e_ethdev.c            |  1 -
>   drivers/net/i40e/i40e_ethdev_vf.c         |  1 -
>   drivers/net/ixgbe/ixgbe_ethdev.c          |  2 --
>   drivers/net/kni/rte_eth_kni.c             |  2 --
>   drivers/net/liquidio/lio_ethdev.c         |  1 -
>   drivers/net/mlx4/mlx4.c                   |  1 -
>   drivers/net/mlx5/mlx5.c                   |  1 -
>   drivers/net/nfp/nfp_net.c                 | 19 ++++++++++++++++---
>   drivers/net/null/rte_eth_null.c           |  2 --
>   drivers/net/pcap/rte_eth_pcap.c           |  1 -
>   drivers/net/ring/rte_eth_ring.c           |  1 -
>   drivers/net/sfc/sfc_ethdev.c              |  2 --
>   drivers/net/softnic/rte_eth_softnic.c     |  1 -
>   drivers/net/tap/rte_eth_tap.c             |  2 +-
>   drivers/net/vhost/rte_eth_vhost.c         |  3 +--
>   drivers/net/virtio/virtio_ethdev.c        |  1 -
>   drivers/net/virtio/virtio_user_ethdev.c   |  1 -
>   drivers/net/vmxnet3/vmxnet3_ethdev.c      |  1 -
>   lib/librte_ether/rte_ethdev.c             | 19 -------------------
>   lib/librte_ether/rte_ethdev.h             |  2 --
>   28 files changed, 19 insertions(+), 57 deletions(-)

<...>

> diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
> index bd09191..cd82b0d 100644
> --- a/drivers/net/sfc/sfc_ethdev.c
> +++ b/drivers/net/sfc/sfc_ethdev.c
> @@ -1791,8 +1791,6 @@ sfc_eth_dev_init(struct rte_eth_dev *dev)
>   	/* Copy PCI device info to the dev->data */
>   	rte_eth_copy_pci_info(dev, pci_dev);
>   
> -	dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE;
> -
>   	rc = sfc_kvargs_parse(sa);
>   	if (rc != 0)
>   		goto fail_kvargs_parse;

<...>