From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id AA5B01B774 for ; Tue, 24 Oct 2017 11:13:59 +0200 (CEST) Received: from pure.maildistiller.com (dispatch1.mdlocal [10.7.20.164]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id F41F46005C; Tue, 24 Oct 2017 09:13:58 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (us4-filterqueue.mdlocal [10.7.20.246]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 1E05A280050; Tue, 24 Oct 2017 09:13:58 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 3A13020059; Tue, 24 Oct 2017 09:13:58 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 24 Oct 2017 10:13:53 +0100 To: Gaetan Rivet , References: <212303ac15d863bd6242bfd75b9056a3d36b95b4.1508833644.git.gaetan.rivet@6wind.com> From: Andrew Rybchenko Message-ID: <91e231c8-369d-b631-d033-da25e3c218fd@solarflare.com> Date: Tue, 24 Oct 2017 12:13:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <212303ac15d863bd6242bfd75b9056a3d36b95b4.1508833644.git.gaetan.rivet@6wind.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23414.003 X-TM-AS-Result: No--8.660900-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1508836438-NpQKhtXcSl8K Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1 1/3] ethdev: remove detachable device flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 09:14:00 -0000 On 10/24/2017 11:59 AM, Gaetan Rivet wrote: > This flag is not necessary at the ether layer anymore. > Buses are able to advertize their hotplug support. The ether layer can > rely upon this capability instead of a special flag. > > Signed-off-by: Gaetan Rivet Acked-by: Andrew Rybchenko > --- > drivers/net/af_packet/rte_eth_af_packet.c | 1 - > drivers/net/ark/ark_ethdev.c | 1 - > drivers/net/avp/avp_ethdev.c | 2 -- > drivers/net/bnxt/bnxt_ethdev.c | 1 - > drivers/net/bonding/rte_eth_bond_pmd.c | 3 +-- > drivers/net/e1000/em_ethdev.c | 1 - > drivers/net/e1000/igb_ethdev.c | 2 -- > drivers/net/fm10k/fm10k_ethdev.c | 1 - > drivers/net/i40e/i40e_ethdev.c | 1 - > drivers/net/i40e/i40e_ethdev_vf.c | 1 - > drivers/net/ixgbe/ixgbe_ethdev.c | 2 -- > drivers/net/kni/rte_eth_kni.c | 2 -- > drivers/net/liquidio/lio_ethdev.c | 1 - > drivers/net/mlx4/mlx4.c | 1 - > drivers/net/mlx5/mlx5.c | 1 - > drivers/net/nfp/nfp_net.c | 19 ++++++++++++++++--- > drivers/net/null/rte_eth_null.c | 2 -- > drivers/net/pcap/rte_eth_pcap.c | 1 - > drivers/net/ring/rte_eth_ring.c | 1 - > drivers/net/sfc/sfc_ethdev.c | 2 -- > drivers/net/softnic/rte_eth_softnic.c | 1 - > drivers/net/tap/rte_eth_tap.c | 2 +- > drivers/net/vhost/rte_eth_vhost.c | 3 +-- > drivers/net/virtio/virtio_ethdev.c | 1 - > drivers/net/virtio/virtio_user_ethdev.c | 1 - > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 - > lib/librte_ether/rte_ethdev.c | 19 ------------------- > lib/librte_ether/rte_ethdev.h | 2 -- > 28 files changed, 19 insertions(+), 57 deletions(-) <...> > diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c > index bd09191..cd82b0d 100644 > --- a/drivers/net/sfc/sfc_ethdev.c > +++ b/drivers/net/sfc/sfc_ethdev.c > @@ -1791,8 +1791,6 @@ sfc_eth_dev_init(struct rte_eth_dev *dev) > /* Copy PCI device info to the dev->data */ > rte_eth_copy_pci_info(dev, pci_dev); > > - dev->data->dev_flags |= RTE_ETH_DEV_DETACHABLE; > - > rc = sfc_kvargs_parse(sa); > if (rc != 0) > goto fail_kvargs_parse; <...>