From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C3E6A0A0E; Thu, 29 Apr 2021 02:51:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 472EF410FB; Thu, 29 Apr 2021 02:51:30 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 2162940697 for ; Thu, 29 Apr 2021 02:51:29 +0200 (CEST) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FVxhW1GnpzvTrw; Thu, 29 Apr 2021 08:48:59 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Thu, 29 Apr 2021 08:51:25 +0800 To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Kantecki, Tomasz" , "Richardson, Bruce" , "thomas@monjalon.net" References: <1616830818-3127-1-git-send-email-humin29@huawei.com> <1618988423-5034-1-git-send-email-humin29@huawei.com> <1618988423-5034-2-git-send-email-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: <9202296b-3294-8f91-32f8-7fdf966b7cfd@huawei.com> Date: Thu, 29 Apr 2021 08:51:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 1/3] examples/flow_classify: fix check of port and core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2021/4/28 21:29, Iremonger, Bernard дµÀ: > Hi Min, > >> -----Original Message----- >> From: Min Hu (Connor) >> Sent: Wednesday, April 21, 2021 8:00 AM >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Iremonger, Bernard >> ; Kantecki, Tomasz >> ; Richardson, Bruce >> ; thomas@monjalon.net >> Subject: [PATCH v2 1/3] examples/flow_classify: fix check of port and core >> >> According to the comments and logging, the author just hope user to use the >> core and device which are in the same numa node for optimal performance. >> If not, A warning gives out. >> >> For example in flow_classify: >> ./build/flow_classify -w 0000:7d:00.1 -l 93 > > The EAL option "-w" has been replaced by the "-a" option in dpdk-20.05 > Hi, thanks Iremonger, fixed in v3. >> Here: >> 0000:7d:00.1 is on numa node 0. >> core 93 is on numa node 3. >> >> The two are not in same numa node, but no warning gives out in old codes. >> >> This patch can fix it. >> >> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") >> Cc: stable@dpdk.org >> >> Signed-off-by: Min Hu (Connor) >> --- >> examples/flow_classify/flow_classify.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/examples/flow_classify/flow_classify.c >> b/examples/flow_classify/flow_classify.c >> index 335d7d2..277a2f5 100644 >> --- a/examples/flow_classify/flow_classify.c >> +++ b/examples/flow_classify/flow_classify.c >> @@ -284,7 +284,7 @@ lcore_main(struct flow_classifier *cls_app) >> * for best performance. >> */ >> RTE_ETH_FOREACH_DEV(port) >> - if (rte_eth_dev_socket_id(port) > 0 && >> + if (rte_eth_dev_socket_id(port) >= 0 && >> rte_eth_dev_socket_id(port) != (int)rte_socket_id()) >> { >> printf("\n\n"); >> printf("WARNING: port %u is on remote NUMA >> node\n", >> -- >> 2.7.4 > > Tested-by: Bernard Iremonger > . >