From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 70E32C2DC for ; Wed, 27 Jan 2016 19:17:33 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id l65so155627567wmf.1 for ; Wed, 27 Jan 2016 10:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=2CTFdH+phKlYRsQb5TLAV7SqtGMRsU2cdHTvEXSt4aM=; b=Rt2lMyRfDz0iGeMyVB4tfpr32EYjAu7RaAJzwN9Jv8VYGctApBR/Tih+HbnaR3bHK0 uAijHUta8CsrVsvcUmXVa06yRJCAoUdrndmhCB2deoCgQO3W3w8k2QlLx4q6vyXpJdJL VP4WqblsrLoIP7EEV0+qJilO5IECNLdQKyeqdePrSDfoWuXT4sZPO0aF9Z8WbvXjsMs6 hZEOShmH3O22y0P/hzMmcJjLrxhUkMr5lr0HBPqP0TGeXD9gvsJaAcRW5dUcE0KWf4Oi 35xOMkX1tFghT34cXuOv/Dm9iVKr6ecfD5eo9GQNOYAAKhTjN+5/Oxs6KdSMrl1t+9Tp x8FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=2CTFdH+phKlYRsQb5TLAV7SqtGMRsU2cdHTvEXSt4aM=; b=CgiDQq1aoSwYxULUHMkMKBMrzZsFyMNKA9ameGvBMJWqCL8qZuQlohAN5N7kCo7pmU auvyM/9qnqLSOFAKiMjzsSymdNCqdCh3jZuIfcaTo4Z47C+OosUbWvcz763XPG6W6SjB xkw7nYpZVn6UA8sytkHX5NhEsB3kFDTYhx1WXiimW1YIWt6UFwZQfF7bguT0OxgNhRd/ yvkzHkdkVT9hL4PKjmvXlJYp4xcFZfXJnQsMLuE20C23nLdmMYVyyUXiYM6e7u7OVWyE 86Ov0ioRKnqxuRAeRzzeK+K7k8w6R0fm+F0bNf5VmU07bkaOYT7UybH/qeAuyImC+hs9 NuxQ== X-Gm-Message-State: AG10YOQ4WrkLp5tOEK7lxwehVpboj1q9r87JRsO1yYaQnko6zCBthrv/8vc1llA2WYtOufyy X-Received: by 10.28.134.147 with SMTP id i141mr33568292wmd.87.1453918653161; Wed, 27 Jan 2016 10:17:33 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id t199sm8790804wmt.23.2016.01.27.10.17.32 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Jan 2016 10:17:32 -0800 (PST) From: Thomas Monjalon To: Huawei Xie Date: Wed, 27 Jan 2016 19:16:23 +0100 Message-ID: <9204020.3pEC1ROqZC@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1453829194-56909-1-git-send-email-huawei.xie@intel.com> References: <1451872319-30737-1-git-send-email-huawei.xie@intel.com> <1453829194-56909-1-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] fix checkpatch errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 18:17:33 -0000 2016-01-27 01:26, Huawei Xie: > v2 changes: > add missed commit message in v1 > > fix the error reported by checkpatch: > "ERROR: return is not a function, parentheses are not required" > > also removed other extra parentheses like: > "return val == 0" > "return (rte_mempool_lookup(...))" How these examples are differents from above checkpatch error? Please add Fixes: 6307b909b8e0 ("lib: remove extra parenthesis after return") This is the second run after above commit but I still see a lot of them. Please check git grep 'return *('