From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 691ED42362; Wed, 11 Oct 2023 18:03:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B03E40279; Wed, 11 Oct 2023 18:03:37 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 15E32400D7 for ; Wed, 11 Oct 2023 18:03:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BD6195C0209; Wed, 11 Oct 2023 12:03:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 11 Oct 2023 12:03:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1697040215; x=1697126615; bh=/p0Y+t5kgMVSigAi1eOwIGg9H6vO35R80jO tIE1hiII=; b=CNRCaxWkbL0DV9To9vkCOhtmGJmJFtksWiCucv1q2XBMeh3h6LT Iu+KFYycSAh12ULCDf/P+j6RLlcK0il9Y9gYvGqYbhfPyKDvokNU9l7QM9RvfrU0 oOha/qC2SX4m7aiXmC3f2uYS1fBuowuZ70KXifzTuHHmdPbjW/U/srqmF/KOTE+w yBEm/bJj+TN1lBIkn3+tJPKtkA2Sx/oAQL29Kc/JZjGxRSoLmEdu5jiqG9fCmwUl Psth3dG0IyQVDXrTGxGbmmn85kZ9sXORKWj4UmrTzGYS/8+hk2nlSAtLgJRWW7F1 /9bp0opWKZKf0qx477MSw7o+AmLCGstnfFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1697040215; x=1697126615; bh=/p0Y+t5kgMVSigAi1eOwIGg9H6vO35R80jO tIE1hiII=; b=bRo9ldRCAqyoqqhsl88dJ9ga1KYVjz1OiR/ESInTdFwa47Co/66 1eaCIRNpME+35ebsnmEa4Z2J/aUwnXKCf4ywSDYWj0khmUehpHyDjmoXAmff79rt fpdq8Nazu5C/cECJ21Zsrxc8Hgegjt9XEnvKU0QK0esjNH+yfBaNMQZKAFM7AD4D s9vEH9lQ/V97ba36o0g3cZRsJQzeL+p/g7k1tl6TYz3GKUVcfxqTnV6geMBbd4TX iAr2AAQUWRwwMbT0uC8IMKfnzcF4obbSEWGj6sibDNfZ/5kqvGzz8OWCd1B4DEWY qmLhLgcLwlZCDS+bpVUWOs6nhA1thyKPgcg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrheekgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 Oct 2023 12:03:34 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Bruce Richardson , David Marchand , dev@dpdk.org Subject: Re: [PATCH] doc: remove confusing command to send patch Date: Wed, 11 Oct 2023 18:03:33 +0200 Message-ID: <9224801.rMLUfLXkoz@thomas> In-Reply-To: References: <20231010162635.755975-1-thomas@monjalon.net> <3707040.MHq7AAxBmi@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/10/2023 12:22, Ferruh Yigit: > On 10/11/2023 11:20 AM, Thomas Monjalon wrote: > > 11/10/2023 10:41, Ferruh Yigit: > >> On 10/11/2023 9:30 AM, Bruce Richardson wrote: > >>> On Wed, Oct 11, 2023 at 10:03:07AM +0200, Thomas Monjalon wrote: > >>>> 11/10/2023 09:30, David Marchand: > >>>>> On Tue, Oct 10, 2023 at 6:26=E2=80=AFPM Thomas Monjalon wrote: > >>>>>> > >>>>>> In the contributor guide, it was said that no need to Cc maintaine= rs > >>>>>> for new additions, probably for new directories not having a maint= ainer. > >>>>>> There is no harm, and it is a good habit, to always Cc maintainers. > >>>>>> > >>>>>> Remove this case as it can mislead to not Cc maintainers when need= ed. > >>>>>> > >>>>>> Signed-off-by: Thomas Monjalon > >>>>> > >>>>> I agree Cc: maintainers should be the default / recommended way of > >>>>> sending patches. > >>>>> > >>>>> Just to convince myself, adding some meson skeleton for a "plop" > >>>>> library, adding an entry in the release notes and hooking in > >>>>> lib/meson.build: > >>>>> $ git show --stat > >>>>> doc/guides/rel_notes/release_23_11.rst | 4 ++++ > >>>>> lib/meson.build | 1 + > >>>>> lib/plop/meson.build | 2 ++ > >>>>> > >>>>> $ ./devtools/get-maintainer.sh 0001-new-awesome-library.patch > >>>>> > >>>>> In this case, it translates to an empty To: list if you follow the > >>>>> example command line: > >>>>> git send-email --to-cmd ./devtools/get-maintainer.sh --cc > >>>>> dev@dpdk.org 000*.patch > >>>>> > >>>>> We could add a default list of recipients if no maintainer is found= by > >>>>> the script. > >>>>> And the next question is who should be in that list.. > >>>> > >>>> Or we can send to dev@dpdk.org, Cc maintainers. > >>>> This is what I do: > >>>> git send-email --to dev@dpdk.org --cc-cmd devtools/get-maintainer.sh > >>>> > >>> +1 for this, mainly on the basis of it being what I do too! :-) > >>> > >> > >> I am for "--to-cmd=3D./devtools/get-maintainer.sh --cc dev@dpdk.org" > >> > >> To highlight response is expected from the maintainers, and community = is > >> informed. > >> > >> Also people may have filters to give higher priority to emails they are > >> in 'to' list, high priority is what we want from maintainers :) > >=20 > > They should give high priority when they are Cc as well. > >=20 > > The problem is that we may have patches with empty "To", > > especially for cover letters and new libs. >=20 > There are indeed, for those cases I am putting 'dev' to "To:". So it would be simpler to recommend a single method with maintainers as Cc.