From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 7E565C44A
 for <dev@dpdk.org>; Mon, 27 Jul 2015 02:37:01 +0200 (CEST)
Received: by wicmv11 with SMTP id mv11so119489486wic.0
 for <dev@dpdk.org>; Sun, 26 Jul 2015 17:37:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=5O/nnd25z7yCny0zpLBf5drZd6qbHUzeIeM8regsFFQ=;
 b=JCsko09KkmGCguJ2qzXtqyBQpe6pPxxEp2ihxsScFR27R7/fDkLaQ+GS6Tf0qcB4y3
 gu1zfIdbN0SsSx3pdy3Fhx8ThmMZTTOZJCVejjxAibVmYg30FU2hmOUuW8wf/GJB+Uhb
 j5wtRsn7lX45KfCq4TyFonAU6PeFQn1QdAHfBM9ReT6zcA5T4dCQn6M/yQjnu7TSIJzn
 3Lb6FcmVT8QrLuNLRisKSJWGc1beKcWx1lHq8U+gXBdNLxXq7/1Ja6MehLchBF5dWTFK
 lkG0xmRe1euVX1sJkg+2uwszHF9is4427zMUgJKsUawWAzjaezfWfvK9CYhsvHyyKxfo
 Glng==
X-Gm-Message-State: ALoCoQk1oFktUuhxz2jD4DPh8GGQivHDWXz16VWkIG9dVQnlET1dWn9e7PY6ElBHOf7OUz40Qo8O
X-Received: by 10.180.23.66 with SMTP id k2mr18201103wif.85.1437957421343;
 Sun, 26 Jul 2015 17:37:01 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id dn8sm10698580wib.12.2015.07.26.17.36.59
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 26 Jul 2015 17:37:00 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ravi Kerur <rkerur@gmail.com>
Date: Mon, 27 Jul 2015 02:35:44 +0200
Message-ID: <9226659.1PhHhf3XUd@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1437852990-6096-3-git-send-email-rkerur@gmail.com>
References: <1437852868-6031-1-git-send-email-rkerur@gmail.com>
 <1437852990-6096-1-git-send-email-rkerur@gmail.com>
 <1437852990-6096-3-git-send-email-rkerur@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v9 3/3] Move common functions in eal_memory.c
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jul 2015 00:37:01 -0000

2015-07-25 12:36, Ravi Kerur:
> --- a/lib/librte_eal/bsdapp/eal/eal_memory.c
> +++ b/lib/librte_eal/bsdapp/eal/eal_memory.c
[...]
> +/*
> + * Wrapper function to initialize contigmem.
> + */
> +int
> +rte_eal_hugepage_init(void)
> +{
> +	return rte_eal_contigmem_init();
> +}

The useless wrapper can be avoid by renaming the function: contigmem_init to
hugepage_init.

> +/*
> + * Wrapper function, no-op here.
> + */
> +void
> +test_proc_pagemap_readable(void)
>  {
> +	return;
>  }
[...]
> --- a/lib/librte_eal/common/eal_private.h
> +++ b/lib/librte_eal/common/eal_private.h
[...]
> +/**
> + * This function checks /proc filesystem
> + * on Linux.
> + *
> + * This function is private to the EAL.
> + */
> +void
> +test_proc_pagemap_readable(void);

This check is specific to Linux. So it should not be in the common file.