From: Ferruh Yigit <ferruh.yigit@intel.com>
To: <20220124065613.2197436-1-jie1x.wang@intel.com>, <dev@dpdk.org>,
"Olivier Matz" <olivier.matz@6wind.com>
Cc: <stevex.yang@intel.com>, <orika@nvidia.com>,
<aman.deep.singh@intel.com>, <thomas@monjalon.net>,
<andrew.rybchenko@oktetlabs.ru>, <jingjing.wu@intel.com>,
<beilei.xing@intel.com>, <qi.z.zhang@intel.com>,
"Jie Wang" <jie1x.wang@intel.com>
Subject: Re: [PATCH v2 2/6] net: fix L2TPv2 common header
Date: Fri, 28 Jan 2022 16:11:56 +0000 [thread overview]
Message-ID: <92347717-5a80-2d18-3f06-d3a809bd5ba4@intel.com> (raw)
In-Reply-To: <20220126063016.2384393-3-jie1x.wang@intel.com>
On 1/26/2022 6:30 AM, Jie Wang wrote:
> The fields of L2TPv2 common header were reversed in big endian and
> little endian.
>
> This patch fixes this error to ensure L2TPv2 can be parsed correctly.
>
Just for reference, checked from RFC:
https://datatracker.ietf.org/doc/html/rfc2661#section-3.1
Change looks good to me. Cc'ed Olivier.
> Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol")
>
Is it candidate for Cc: stable@dpdk.org backport?
> Signed-off-by: Jie Wang <jie1x.wang@intel.com>
<...>
next prev parent reply other threads:[~2022-01-28 16:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 6:30 [PATCH v2 0/6] support L2TPv2 for AVF RSS hash and FDIR Jie Wang
2022-01-26 6:30 ` [PATCH v2 1/6] ethdev: add L2TPv2 RSS offload type Jie Wang
2022-01-28 16:11 ` Ferruh Yigit
2022-01-29 6:04 ` Wang, Jie1X
2022-01-26 6:30 ` [PATCH v2 2/6] net: fix L2TPv2 common header Jie Wang
2022-01-28 16:11 ` Ferruh Yigit [this message]
2022-01-29 6:09 ` Wang, Jie1X
2022-01-26 6:30 ` [PATCH v2 3/6] app/testpmd: add 6 types of L2TPv2 message Jie Wang
2022-01-28 16:12 ` Ferruh Yigit
2022-01-26 6:30 ` [PATCH v2 4/6] common/iavf: add session ID fields for L2TPv2 Jie Wang
2022-01-26 6:30 ` [PATCH v2 5/6] net/iavf: support L2TPv2 for AVF HASH Jie Wang
2022-01-26 6:30 ` [PATCH v2 6/6] net/iavf: support L2TPv2 for AVF FDIR Jie Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92347717-5a80-2d18-3f06-d3a809bd5ba4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=20220124065613.2197436-1-jie1x.wang@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jie1x.wang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=qi.z.zhang@intel.com \
--cc=stevex.yang@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).