From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3BD1A034E; Fri, 28 Jan 2022 17:26:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75C4742822; Fri, 28 Jan 2022 17:26:04 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 05FB540041 for ; Fri, 28 Jan 2022 17:26:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643387163; x=1674923163; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=ZQs3SKQ855Rqd5x8GdonoPNQv8AJFMyeXVYL5rodR8A=; b=hyy6MeCftBwo3VS2o8QDrtM2BpsZMda85A6spt0yDcoLxDSSmTrh7N7b 4/TwgwyuAVsMfD9lYkR2Uw8vnwOg84d4+XXX3Y9+TDLE5u3LSrELD0NfU ZwP8QXjK6jFEfAVM23udu2h1nSxXjkcqAGZP7Z3c+WD+CXSv3IlkyM6YO jTyPt7eDcQEM6UVqFy/STuDv9rxwpSH2uHrcpkAbyDtRUQMj4qQzlrk24 1OWAqOzCHiIxoUoObG2IG+35Y4NHxgoVlMJmZeTsap0Bj55igMSZsUBb9 VQlqagbMWrnQ8WQUR31f5y+hKlXB52d3wv493DoYZfHvQVXr4uoReeXVf g==; X-IronPort-AV: E=McAfee;i="6200,9189,10240"; a="307869012" X-IronPort-AV: E=Sophos;i="5.88,324,1635231600"; d="scan'208";a="307869012" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2022 08:12:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,324,1635231600"; d="scan'208";a="496174581" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 28 Jan 2022 08:12:11 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 28 Jan 2022 08:12:11 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 28 Jan 2022 08:12:11 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 28 Jan 2022 08:12:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JBIIfwEsd/+5uDNatJWhFaLSlUL+a4kHNLoZPMkb9gI6M7AJ4GSXAnbzzc/DT9iGFaPF9bsS2a91F/f+1n4VSDQ2EilQVsltFrEy3dwrPvA+h+AZh9qSV3iYG3VtF+yFu8mK5tdV0Ru+8RDwkXz3xlI5hTm4ZJl2EP/OJOkkkOscexa0e2Gu1MhP359E2EvEGJUR5TGVaWod6v9j/5M0xcb5S3bzPsj7Ypz5KCgjF8lmMtZ5AOyMFxtUAOQ/+xyjERuwsPuUiYJxUAQGMjkrem8SzyXkOcqb76pw3jLYy2AcOqwYGsZT0FQSQDMz/F8+WnqaSBMUqudYzNRup+mFlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=leBp05piLqWQWE00fammMH4Ow8Lt8qa7iOmoJidvBns=; b=IukX7GyP6BKIrIARt03SuDjMOZdXqMjm3LBFO4JxL5nlnZv8M9hvpOmCadtujFUavRMv0S+IWX0Kw/1ZECMsHj1qw89pZf4g47dfXUKPQbFHHAI+yz4XRNEYxYbCC5LIgJtwaCRQ4QQIdh+OV64lfThkDNG5ooIse6sftSvwniL7UVTjL0iY3GY3ALXii73kUPHqy6F6dLQfK9442jhgdUewVLK3ixIkH+5HfYLu//cSLWj8aiBjrawohei01uOqQ2SMGMGzhcMfnO5A/mkewBZ0IyWSno8THoR9cuK7WtnewD2S/gHu930r+teXihqRON1LHYCvZmL0QTC1j3w9IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SA2PR11MB4891.namprd11.prod.outlook.com (2603:10b6:806:11e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Fri, 28 Jan 2022 16:12:03 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4930.019; Fri, 28 Jan 2022 16:12:03 +0000 Message-ID: <92347717-5a80-2d18-3f06-d3a809bd5ba4@intel.com> Date: Fri, 28 Jan 2022 16:11:56 +0000 Content-Language: en-US To: <20220124065613.2197436-1-jie1x.wang@intel.com>, , "Olivier Matz" CC: , , , , , , , , "Jie Wang" References: <20220126063016.2384393-1-jie1x.wang@intel.com> <20220126063016.2384393-3-jie1x.wang@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v2 2/6] net: fix L2TPv2 common header X-User: ferruhy In-Reply-To: <20220126063016.2384393-3-jie1x.wang@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0455.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::10) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c5533c2-8f94-497e-460e-08d9e278eba3 X-MS-TrafficTypeDiagnostic: SA2PR11MB4891:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2399; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zTLjxCjKkzVapo9OsU//d3UUCmGVwpRvSG4ZrbfzcjXuWVruVg3R7sQpVp2pTgx1rHSDJGrWUuwdoH9uyN8KSa7CTumvtxoUR71AAv/HQ50vYvzGmpbCi1GI3fWyzBN6G+z5meMxR3mPD5syLAERAZ6EPf39CaJzkxCuzWIgAVLAGeb03psbeBIQCmumXkOreagHQPvxit8pNqIdqhAUWmQR5TTxSbPsqgguobSEiaaAQXQEpx43NPlGQu9enG3+U8/Ps6mRpFlIPZo90D00zKPiIb4JontJqzizemUda2q2AB9p6KejA9T7IWgvP/XQL3TtyIm0KbJCQhtIxcxcUDVTNB7w+nlL04YdE1NUC/n9KXG5JmlRnkrLGfQR11dEu2vZRr0J1Vi8/ZLOB7QVDlcwo/23Ez4mRiCHqn95EAlZpqbsbkqbz9owwcuFdNronEoyWNDesuxW+0lLPa6kDXiApEGuAS1TQ20x7+qdIOaLDhTwf7aVCjCxluO66KZGOeIRADoG+VShkBfwV/OMyVf8igHNAturzslpmmhFVH99zWv8myNvi3EAefKOJBhq932uCHZGJx3YW83ymhVPGtf/16N3f+C9oHi+tO+ljBxt81HFWWVmdGMTKVRZ3Gax5mVogTTNp8rVvW7V4xCXfx0NMSdrL7mj2rey9KwF0AsD1jqIEODNdcLdgzFyIB4LIXYye5dviWnLq90OXXSt81MYt+hqLdyGuKmvdo7ZDCHStTRBMqR4gNyESncM9W4joUuonakRB3PcjcAPumSqPmJslF3Lg7mpfA44vK1OoSk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(6512007)(6666004)(316002)(86362001)(508600001)(53546011)(966005)(6486002)(6916009)(31696002)(66946007)(8676002)(36756003)(44832011)(31686004)(186003)(26005)(2616005)(38100700002)(4326008)(66476007)(107886003)(5660300002)(66556008)(8936002)(2906002)(4744005)(82960400001)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm0yTnRQbkZZcHFzR1RmZWtIV0VET2MvWTArcU8wbEFYMEFYemgxUkJSM3JN?= =?utf-8?B?bVVTcWlxU3I1NS9DZkZ2ZVJsaUZoZktRcnk0eXVxU1M2TUVzSkJiWHVhMjFX?= =?utf-8?B?Q0dIQWNrME1nT0U4ZWtWcHhSVlV2YWNwZk1sVTFITkY0Nms3M0Y2UHIzdnE0?= =?utf-8?B?ZVcydWtQWUdORUNnRmM4QkdYYmpqa293WmVFZXNlMGpBaFd3dFZUWHBSQ2w4?= =?utf-8?B?VUdrdHVGc2ZGSUZSSFVyN2ZWM3AxN1hJdzlZWDErdjRiYXhsckRFYXJrUWps?= =?utf-8?B?Wnk1a2xvY3NUZnlzaUZWMGtBUiszbTRqN1JyaEVpTStKUXRjUDFNUGRsdUNO?= =?utf-8?B?T21JdlJ3MFlrVE92Q1A4SlFPcUpqODJ5RG10ZXBJb1hSRE4zVDBEK0pSdVVs?= =?utf-8?B?U1U4ZEQvczYrZ2NMYzBKUFV1UWtxdVo2VHVWUTZld0FTQ3RHL1FRL1J0azFG?= =?utf-8?B?M0lVU0ZseDRuOUJaRkgyb0JqTmlqRXhnQWxQSm9GQ2xTcGZUY0FnbVdwU1BS?= =?utf-8?B?UkZVRDlOT3JuZWgzUDNUUFNrckUvWCtVVXZCbUhiY0M3K212WEpHRngzYUVC?= =?utf-8?B?K01iT2JwRFpueVRwQUlabzdEcnJRaXRFOEgvWnJJNEkwQlk0Wkh4SkYxQTEy?= =?utf-8?B?RzUrTnI5ZEtxZDRSRW55Z25OUmIrMW8vRlFMOStEeDExeDFqNFNoTGRpcGhi?= =?utf-8?B?UGx0Q3BadU1JelpMNzhZUmo4bHdnRTAwOFZiTTdPRG45SkZ5Vy95V0NJQ1ZW?= =?utf-8?B?eHdoWGc2YWdPTS9DVW9pV2YyTUNIeUQ0MytlTjJBNmlaVlhCa0ZIRGxsTTFI?= =?utf-8?B?K2xrcHNrWGRSTDJBSCtiRHdPV2N6eW8xeFI3cVhzWTlLUE5mYmFzemdvOWVN?= =?utf-8?B?V2paeWhMUzlnZmwzNTJZOEYxNnY3eXgrNWNhOEpNL0RydDR1YWRwTVFFY3ZB?= =?utf-8?B?SWdmUmVlMFdTRFA2OGRkdUlrK1YvWWZtU1BCdG1lUDc2NjA5L1dzdG1BZGhx?= =?utf-8?B?UXlRMGZzdHd5T29OVDk5U0RHV3czVmxrTXZuSlRnUlQ4OTNjY2dNanZLRmlQ?= =?utf-8?B?dkkxYy8zTUpSY1gyZWZNZ1ZBSlcyUm9kMlRNWGEzcE9zangxelBndnpQaHlV?= =?utf-8?B?UDhJQzRjU1Nyc2cybWJwVmxTeHpJTE1ZWm9lZ2xVUnZ4bk1HaGxjdG0ycG9F?= =?utf-8?B?SlJKdUpjcWhRTTdFUitEVFRVSytGNkR5UGx2aEl6UDNIRXRMYXAwV3dweXhq?= =?utf-8?B?VXQxdjZ2Ryt3eTBLZWdYZ3JEVTJ5NkRqKy90WHZzb21NWDFkcjg5eWJkNHdR?= =?utf-8?B?S0x0MW9DbEFIY0NwK0dtVTRTdG00UXBkck5zMmVGdTJaUHc3eldhME0wRlVl?= =?utf-8?B?RG9pMnQxcThRalVuWDhCUEJLYVNER0UydlVoMlZTOGxaYWk2NHNndVhHL0tv?= =?utf-8?B?VzBTOVExc3VGWTNQZ1gybFhkK2Exd3RTdWVIWEZ3TFh2UkxPaGhsMUkxa1Nk?= =?utf-8?B?OGViUTNVRnBFVUpySUtPM3hQcVJJcUZKdjlYcDlXREJMMlZnczM3cy9KSERP?= =?utf-8?B?T1R6VnFmcDJoanVya0g0WUpFU01sdlFYTGh2TFdFYTVSbmFCRHM4SHV6anpO?= =?utf-8?B?ZncydFduUCtvS2dEUE4vS0xPN3J2NEM1MHQ3YlNwMmVRSVJmRWd0UVZNU0lw?= =?utf-8?B?NkYvd2ZJU0FyQWZWQjNsbjJDWHp5aGhEczgrMXUwc1lQRzJhci8vZzJFeExo?= =?utf-8?B?clM0cGRreFE4QTlkWVh1amxBNVA5NlZzOFk4NDFpT0VReWlYd2g1TktSRzg0?= =?utf-8?B?QzZTUXozM1gwQ1JzTG51b0ZyNks5YmY1KzhrU3M0b0R1VXlidEhEMzUwYWlY?= =?utf-8?B?SzZJSzdmUGYyc1NRZXZTNGlQaXhZWTJDb2krcHZYSjJISitVUmtwZFhKZ3pB?= =?utf-8?B?Slc0TGtUc003OFlBWmQreTNSSFZLYjlORnJwYkUwTVlqWWU5VHhrK0FoNldP?= =?utf-8?B?NHlOY0YyazV3OVhwTHR6c2kyNTF3U2FrU2JoY0dSS0pGTDYxZGI5cG5DU0lq?= =?utf-8?B?WkJNUkNJQUlHWlMxbFIzZVpBSUhDdi9KMytpNGVBVDBhRzg4YVRQU3ZlcTI0?= =?utf-8?B?OXRYaE01YmllTnhWd2VBaUtnM0NlazhoSTFGbkx2SlN2cDIrU091T0JIZnB2?= =?utf-8?Q?Ziwt1BetzXqnlpVVjihCrzU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5c5533c2-8f94-497e-460e-08d9e278eba3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2022 16:12:02.9901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7PyY1DrKncYNVd+TUKPpqw3NVmb5KKbTZ1XTshEAK/aZv+oNgtSmgoPI5N+4K8tIeXQ3BqTBcaQENZAF4YNpQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4891 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/26/2022 6:30 AM, Jie Wang wrote: > The fields of L2TPv2 common header were reversed in big endian and > little endian. > > This patch fixes this error to ensure L2TPv2 can be parsed correctly. > Just for reference, checked from RFC: https://datatracker.ietf.org/doc/html/rfc2661#section-3.1 Change looks good to me. Cc'ed Olivier. > Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") > Is it candidate for Cc: stable@dpdk.org backport? > Signed-off-by: Jie Wang <...>