From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7802F101B for ; Tue, 19 Sep 2017 18:37:20 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2017 09:37:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,418,1500966000"; d="scan'208";a="1016234465" Received: from aburakov-mobl2.ger.corp.intel.com (HELO [10.237.210.143]) ([10.237.210.143]) by orsmga003.jf.intel.com with ESMTP; 19 Sep 2017 09:37:02 -0700 To: Santosh Shukla , dev@dpdk.org References: <20170831032618.7120-1-santosh.shukla@caviumnetworks.com> <20170918104234.9149-1-santosh.shukla@caviumnetworks.com> <20170918104234.9149-3-santosh.shukla@caviumnetworks.com> From: "Burakov, Anatoly" Message-ID: <92424c77-29d5-4e4e-7f53-22c015d24fb3@intel.com> Date: Tue, 19 Sep 2017 17:37:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170918104234.9149-3-santosh.shukla@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 2/9] eal/pci: get iommu class X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Sep 2017 16:37:20 -0000 On 18-Sep-17 11:42 AM, Santosh Shukla wrote: > Introducing rte_pci_get_iommu_class API which helps to get iommu class > of PCI device on the bus and returns preferred iova mapping mode for > PCI bus. > > Patch also add rte_pci_get_iommu_class definition for bsdapp, > in bsdapp case - api returns default iova mode. > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob > Reviewed-by: Maxime Coquelin > --- Hi Santosh, You have probably missed my comment on previous version of this patch, but for commit history reasons i really think you should add a linuxapp stub in this commit as well as a FreeBSD stub, even though you are adding a linuxapp function in the next commit. Any linuxapp application using that function will fail to compile with this commit, despite this API being already present and declared as public. -- Thanks, Anatoly