From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 8FCEC1B95E for ; Thu, 10 May 2018 13:17:20 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 2C499100059; Thu, 10 May 2018 11:17:19 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 10 May 2018 12:17:14 +0100 To: Thomas Monjalon , CC: Matan Azrad References: <20180509094337.26112-1-thomas@monjalon.net> <20180509224313.27289-1-thomas@monjalon.net> <20180509224313.27289-12-thomas@monjalon.net> From: Andrew Rybchenko Message-ID: <924a1489-a8c7-e84b-380b-69e5c1ec9713@solarflare.com> Date: Thu, 10 May 2018 14:17:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180509224313.27289-12-thomas@monjalon.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23834.003 X-TM-AS-Result: No--1.333300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1525951040-7iWKpPXB6zZL Subject: Re: [dpdk-dev] [PATCH v2 11/11] ethdev: fix port removal notification timing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 11:17:20 -0000 On 05/10/2018 01:43 AM, Thomas Monjalon wrote: > From: Matan Azrad > > When an ethdev port is released, a destroy event is triggered to notify > the users about the released port. > > A bit before the destroy event is triggered, the port becomes invalid > by changing its state to UNUSED and cleaning its data. Therefore, the > port is invalid for the destroy event callback process and the users > may get a wrong information of the port. > > Move the destroy event emitting to be called before the port > invalidation. > > Fixes: 133b54779aa1 ("ethdev: fix port data reset timing") > Fixes: 29aa41e36de7 ("ethdev: add notifications for probing and removal") > Cc: stable@dpdk.org > > Signed-off-by: Matan Azrad > Acked-by: Thomas Monjalon > Reviewed-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko