Re: [dpdk-dev] [PATCH v3] net/virtio: fix Rx scatter offload

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 7/21/21 11:29 AM, Andrew Rybchenko wrote:
> On 7/20/21 7:19 PM, Maxime Coquelin wrote:
>>
>>
>> On 7/20/21 9:54 AM, Andrew Rybchenko wrote:
>>> From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
>>>
>>> Report Rx scatter offload capability depending on
>>> VIRTIO_NET_F_MRG_RXBUF.
>>>
>>> If Rx scatter is not requested, ensure that provided Rx buffers on
>>> each Rx queue are big enough to fit Rx packets up to configured MTU.
>>>
>>> Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
>>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>> ---
>>> v3:
>>>   - fix segfault on MTU set if an Rx queue is not setup
>>>
>>> v2:
>>>   - do not overwrite Rx offloads when Rx scatter is added
>>>
>>>   drivers/net/virtio/virtio.h        |  2 +
>>>   drivers/net/virtio/virtio_ethdev.c | 65 ++++++++++++++++++++++++++++++
>>>   drivers/net/virtio/virtio_ethdev.h |  5 +++
>>>   drivers/net/virtio/virtio_rxtx.c   | 10 +++++
>>>   4 files changed, 82 insertions(+)
>>>
>>
>> Thanks for the fix.
>> I see my R-by is already there, but I confirm this is good to me.
> 
> It was inherited from v1, since changes from v1 to v3 are really minor
> fixes.
> 

Yes, no problem. I was just to let Chenbo know, so that he can add it to
the PR.

Maxime