From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id ADCAD1B204 for ; Wed, 27 Mar 2019 00:57:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 50A04220B9; Tue, 26 Mar 2019 19:57:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 19:57:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=C36Jfq/ct/B/dqa7k68y6UOjAgqqINqH+LTq4RKdqC8=; b=RAq9JpjfIg/D 8mOriDQ0DWOmZ0Nz7AaResNdNdYktzcWhII+434xWcjP5rnA0FesrK1DfDNfQ1/p /MVEybG7JbkPQsgfeNcdl5q6Nb8WgawyaTzSDuoYtlLIxg7Lw0STqsMW/p8wjuTF dKUA9K5h5W27P8mIM18WvfR/cHnv2N8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=C36Jfq/ct/B/dqa7k68y6UOjAgqqINqH+LTq4RKdq C8=; b=2L9xoh3cjm3yMcoatWqyrnNSa3X00ggYoAUi0rif6HkAP9lM4hf0EuiWF WNElkeeA+L1HFy+3MVgBvzmVRMwPU+3yDqAxAsl2p8DDwdUBjW2mrJGJiJp/pCju uysrN0ngOQhG1+OvdwcpeGTxEVANsWwVuE6AkuT4rq6rt39RH1D7CSbGenKUNNpV TWKsIJDPxVAsx6wGLhi7XsniRnD/xylKNM+YXGi0H6uppH3YjSkT2/rZ7LAg32Ln frgPVQR6lk9EaubPUriTMqTqAhAahZa76pV7LNg3HB0w1skryE027EJyO27lGBFZ eGbxy0k/lpPRzJHQtk9vsXz6S7r/g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedugdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C82961030F; Tue, 26 Mar 2019 19:57:51 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@intel.com, jerin.jacob@caviumnetworks.com Date: Wed, 27 Mar 2019 00:57:50 +0100 Message-ID: <9251831.JcUeV1QU0H@xps> In-Reply-To: <20190313150958.22581-1-bruce.richardson@intel.com> References: <20190313150958.22581-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: fix invalid config check when building tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2019 23:57:53 -0000 13/03/2019 16:09, Bruce Richardson: > The check for a valid configuration in build-tags.sh relied on the output > of "make showconfig" rather than checking directly for a config file of > that name. This broke when as part of the rename of the linuxapp/bsdapp > configs to just linux/freebsd, as we stopped advertising the old names > even if they worked. Changing the code to just look for the config > file by name fixes this issue while shortening the code too. > > Fixes: 218c4e68c1d9 ("mk: use linux and freebsd in config names") > Fixes: aafaea3d3b70 ("devtools: add tags and cscope index generation") > > Signed-off-by: Bruce Richardson Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7B29EA05D3 for ; Wed, 27 Mar 2019 00:57:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C9A81B207; Wed, 27 Mar 2019 00:57:54 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id ADCAD1B204 for ; Wed, 27 Mar 2019 00:57:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 50A04220B9; Tue, 26 Mar 2019 19:57:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 19:57:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=C36Jfq/ct/B/dqa7k68y6UOjAgqqINqH+LTq4RKdqC8=; b=RAq9JpjfIg/D 8mOriDQ0DWOmZ0Nz7AaResNdNdYktzcWhII+434xWcjP5rnA0FesrK1DfDNfQ1/p /MVEybG7JbkPQsgfeNcdl5q6Nb8WgawyaTzSDuoYtlLIxg7Lw0STqsMW/p8wjuTF dKUA9K5h5W27P8mIM18WvfR/cHnv2N8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=C36Jfq/ct/B/dqa7k68y6UOjAgqqINqH+LTq4RKdq C8=; b=2L9xoh3cjm3yMcoatWqyrnNSa3X00ggYoAUi0rif6HkAP9lM4hf0EuiWF WNElkeeA+L1HFy+3MVgBvzmVRMwPU+3yDqAxAsl2p8DDwdUBjW2mrJGJiJp/pCju uysrN0ngOQhG1+OvdwcpeGTxEVANsWwVuE6AkuT4rq6rt39RH1D7CSbGenKUNNpV TWKsIJDPxVAsx6wGLhi7XsniRnD/xylKNM+YXGi0H6uppH3YjSkT2/rZ7LAg32Ln frgPVQR6lk9EaubPUriTMqTqAhAahZa76pV7LNg3HB0w1skryE027EJyO27lGBFZ eGbxy0k/lpPRzJHQtk9vsXz6S7r/g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedugdduhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C82961030F; Tue, 26 Mar 2019 19:57:51 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@intel.com, jerin.jacob@caviumnetworks.com Date: Wed, 27 Mar 2019 00:57:50 +0100 Message-ID: <9251831.JcUeV1QU0H@xps> In-Reply-To: <20190313150958.22581-1-bruce.richardson@intel.com> References: <20190313150958.22581-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] devtools: fix invalid config check when building tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326235750.vagnfTUZg92UVpGamJl0im0pdP3Q36Jq7hA8JxyU6OY@z> 13/03/2019 16:09, Bruce Richardson: > The check for a valid configuration in build-tags.sh relied on the output > of "make showconfig" rather than checking directly for a config file of > that name. This broke when as part of the rename of the linuxapp/bsdapp > configs to just linux/freebsd, as we stopped advertising the old names > even if they worked. Changing the code to just look for the config > file by name fixes this issue while shortening the code too. > > Fixes: 218c4e68c1d9 ("mk: use linux and freebsd in config names") > Fixes: aafaea3d3b70 ("devtools: add tags and cscope index generation") > > Signed-off-by: Bruce Richardson Applied, thanks