* [dpdk-dev] [PATCH] fm10k: fix improper RETA table config
@ 2015-07-10 8:19 Chen Jing D(Mark)
2015-07-10 8:20 ` Qiu, Michael
0 siblings, 1 reply; 3+ messages in thread
From: Chen Jing D(Mark) @ 2015-07-10 8:19 UTC (permalink / raw)
To: dev; +Cc: shaopeng.he
From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
fm10k has 128 RETA entries in 32 registers, but it only initialized
first 32 when doing multiple rx queue configurations. This fix will
initialize all 128 entries instead.
Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
---
drivers/net/fm10k/fm10k_ethdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index f12d0c8..a300711 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -329,7 +329,7 @@ fm10k_dev_mq_rx_configure(struct rte_eth_dev *dev)
* little-endian order.
*/
reta = 0;
- for (i = 0, j = 0; i < FM10K_RETA_SIZE; i++, j++) {
+ for (i = 0, j = 0; i < FM10K_MAX_RSS_INDICES; i++, j++) {
if (j == dev->data->nb_rx_queues)
j = 0;
reta = (reta << CHAR_BIT) | j;
--
1.7.7.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: fix improper RETA table config
2015-07-10 8:19 [dpdk-dev] [PATCH] fm10k: fix improper RETA table config Chen Jing D(Mark)
@ 2015-07-10 8:20 ` Qiu, Michael
2015-07-10 20:42 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Qiu, Michael @ 2015-07-10 8:20 UTC (permalink / raw)
To: Chen, Jing D, dev; +Cc: He, Shaopeng
On 7/10/2015 4:19 PM, Chen, Jing D wrote:
> From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
>
> fm10k has 128 RETA entries in 32 registers, but it only initialized
> first 32 when doing multiple rx queue configurations. This fix will
> initialize all 128 entries instead.
>
> Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
Acked-by: Michael Qiu <michael.qiu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: fix improper RETA table config
2015-07-10 8:20 ` Qiu, Michael
@ 2015-07-10 20:42 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-07-10 20:42 UTC (permalink / raw)
To: Chen, Jing D; +Cc: dev, He, Shaopeng
2015-07-10 08:20, Qiu, Michael:
> On 7/10/2015 4:19 PM, Chen, Jing D wrote:
> > From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
> >
> > fm10k has 128 RETA entries in 32 registers, but it only initialized
> > first 32 when doing multiple rx queue configurations. This fix will
> > initialize all 128 entries instead.
> >
> > Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
>
> Acked-by: Michael Qiu <michael.qiu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-10 20:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-10 8:19 [dpdk-dev] [PATCH] fm10k: fix improper RETA table config Chen Jing D(Mark)
2015-07-10 8:20 ` Qiu, Michael
2015-07-10 20:42 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).